network tests#145
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new network-focused tests to the Rewind test suite to lock down URL request construction details and Remote retry/cancellation behavior.
Changes:
- Adds characterization tests verifying
Network.Request.byBoundsencodes GeoJSON Polygon coordinates with the required extra ring nesting. - Adds tests verifying
Network.Request.imagestrips unexpected query parameters from image paths when building CDN URLs. - Adds behavioral async tests for
Remote.exponentialBackoff, including retry-until-success and cancellation aborting pending retries.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| RewindTests/RequestBuildingTests.swift | Tests URL building for byBounds params JSON structure and image URL query stripping. |
| RewindTests/RemoteBackoffTests.swift | Tests Remote.exponentialBackoff retry and cancellation behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+48
to
+50
| while await counter.n < 1 { | ||
| await Task.yield() | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.