Skip to content
This repository was archived by the owner on Jul 26, 2026. It is now read-only.
This repository was archived by the owner on Jul 26, 2026. It is now read-only.

Incorrect iPad frame mappings/assets for iPad mini and 2024 iPads #66

Open

Description

@zhuhaow

Summary

Several iPad frame mappings/assets in appshot-cli appear to be wrong in the current npm release and current GitHub main.

I hit this while generating App Store marketing screenshots and was able to reproduce three separate problems:

  1. iPad mini 2021 is mapped to the wrong screenshot size in frames-loader
  2. 2064x2752 is mapped to ipad pro 2024 11 in devices
  3. The shipped 2024 13-inch frame assets appear malformed

Repro details

1. iPad mini mapping is wrong

In src/core/frames-loader.ts, ipad mini 2021 is currently treated as:

'ipad mini 2021': { portrait: { width: 1620, height: 2160 }, landscape: { width: 2160, height: 1620 } }

But the actual iPad mini screenshot lane used by current simulators/devices is 1488x2266 / 2266x1488.

With a real 1488x2266 screenshot, appshot does not treat the mini frame correctly. In my local run this produced a framed PNG with a transparent band between the screen content and the bottom bezel.

2. 2064x2752 maps to the wrong device

In src/core/devices.ts, the exact-resolution mapping currently includes:

'2064x2752': 'ipad pro 2024 11'

Apple treats 2064x2752 as the 13-inch iPad App Store lane, not 11-inch. In practice this causes appshot to select the wrong frame for that screenshot size.

3. 2024 13-inch frame assets look malformed

The bundled iPad Pro 2024 13 portrait and landscape PNG assets appear to have obviously wrong canvas dimensions for a 13-inch frame. That lines up with the broken output when 2064x2752 is framed.

What I observed locally

  • 1668x2388 -> older 11-inch frame path worked cleanly
  • 1640x2360 -> iPad Air path worked cleanly
  • 1488x2266 -> mini path was broken
  • 2064x2752 -> selected the wrong 2024 iPad frame path and produced bad output

Expected behavior

  • 1488x2266 should resolve cleanly to the iPad mini frame
  • 2064x2752 should not resolve to ipad pro 2024 11
  • the shipped 2024 13-inch frame assets should produce a correct framed output without transparent gaps or incorrect screen placement

Requested fix

I think the fixes are likely:

  • update ipad mini 2021 resolution metadata to 1488x2266 / 2266x1488
  • correct the exact-resolution mapping for 2064x2752
  • replace or repair the malformed 2024 13-inch frame assets

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions