Skip to content

Comments

Added Firefox 44 in pinning-test#314

Open
prefixtitle wants to merge 3 commits intochromium:masterfrom
prefixtitle:patch-1
Open

Added Firefox 44 in pinning-test#314
prefixtitle wants to merge 3 commits intochromium:masterfrom
prefixtitle:patch-1

Conversation

@prefixtitle
Copy link
Contributor

@prefixtitle prefixtitle commented Sep 11, 2017

image

pinning-test.badssl.com was added to Firefox 44 by bug ID: 1218515.

Added wikipedia to HPKP and line break.

Solves issue #298 and #307.

@lgarron
Copy link
Contributor

lgarron commented Sep 12, 2017

Thanks!

Could you do at least two things?

  • Fit the text on two lines (no explicit line break).
  • Avoid phrasing the "official Chrome builds" explanation in a way that implies that it's not present in any Firefox builds.

@prefixtitle
Copy link
Contributor Author

image

Done.

@lgarron lgarron force-pushed the master branch 3 times, most recently from 1d2c736 to 8b893ec Compare October 20, 2017 19:06
@lgarron lgarron force-pushed the master branch 2 times, most recently from 1dfcd2b to 9ca20c0 Compare April 21, 2018 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants