Bugfix for broken RequestUpdateScript*() functions

[mercurylinden]

Description

When trying to use the RequestUpdateScript*Async() functions, the uploadStatus response would always be "Failed to parse capability response: Unable to deserialize data: unrecognized format." The issue is that PostStringAsync(cap, msg.Serialize(), ...) takes a string as its second parameter, but msg.Serialize() returns an OSDMap. OSDMap inherits from OSD which has public static implicit operator string(OSD value) { return value.AsString(); }, and OSDMap.AsString() falls back to the base implementation returning string.Empty, so an empty string is getting sent as the message.

The fix is to use PostCapAsync instead of PostStringAsync. It takes an OSD directly and serializes it properly as XML LLSD before posting.

Changes

• Replaced calls to PostStringAsync with PostCapAsync in RequestUpdateScriptAgentInventoryAsync and RequestUpdateScriptTaskAsync

Testing

dotnet build project built successfully
dotnet test all tests passing

[cinderblocks]

A sound fix! Thank you.