feat: delegate credential loading to protect-ffi#326
Conversation
Remove eager workspace CRN checks from ProtectClient and EncryptionClient constructors — protect-ffi now handles credential resolution internally via stack-auth and the cipherstash profile. - Remove loadWorkSpaceId calls and unused clientInfo methods - Override protect-ffi to use local linked build - Use ensureKeyset in keyset tests instead of hardcoded UUIDs
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
ProtectClientandEncryptionClientconstructors. Credential resolution (workspace CRN, access key, client key) is now fully handled byprotect-ffiviastack-authand the~/.cipherstashprofile — no env vars orcipherstash.tomlrequired.ensureKeysetfrom protect-ffi in keyset tests instead of hardcoded UUIDs, so tests create/find the keyset dynamically.Dependency