Skip to content

feat: delegate credential loading to protect-ffi#326

Draft
coderdan wants to merge 2 commits intomainfrom
feat/update-ffi
Draft

feat: delegate credential loading to protect-ffi#326
coderdan wants to merge 2 commits intomainfrom
feat/update-ffi

Conversation

@coderdan
Copy link
Contributor

@coderdan coderdan commented Mar 21, 2026

Summary

  • Remove eager workspace CRN checks from ProtectClient and EncryptionClient constructors. Credential resolution (workspace CRN, access key, client key) is now fully handled by protect-ffi via stack-auth and the ~/.cipherstash profile — no env vars or cipherstash.toml required.
  • Use ensureKeyset from protect-ffi in keyset tests instead of hardcoded UUIDs, so tests create/find the keyset dynamically.
  • Upgrade EQL to 2.2.1 in the local Docker setup.

Dependency

This PR depends on a new version of @cipherstash/protect-ffi which has not yet been published. The pnpm override in package.json currently points to a local link. Before merging, protect-ffi must be published and the override replaced with the published version.

Remove eager workspace CRN checks from ProtectClient and
EncryptionClient constructors — protect-ffi now handles credential
resolution internally via stack-auth and the cipherstash profile.

- Remove loadWorkSpaceId calls and unused clientInfo methods
- Override protect-ffi to use local linked build
- Use ensureKeyset in keyset tests instead of hardcoded UUIDs
@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2026

⚠️ No Changeset found

Latest commit: 60a3c3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Mar 21, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d224c588-b9c8-48ec-b5c9-aae1a30de0f8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/update-ffi

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant