Add a commented-out exclude for Pipfile.lock to the pretty-format-json pre-commit hook#261
Open
Add a commented-out exclude for Pipfile.lock to the pretty-format-json pre-commit hook#261
exclude for Pipfile.lock to the pretty-format-json pre-commit hook#261Conversation
This exclude is uncommented in multiple downstream repos that use pipenv to simply allow it format those files however it wants; we don't care about prettifying them since they are for the most part only read by machines.
jsf9k
added
the
kraken 🐙
github-actions
bot
added
the
dependencies
Closed
6 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the repository’s pre-commit configuration around pretty-format-json to address handling of Pipfile.lock files (commonly present in downstream pipenv-based repos).
Changes:
- Adds commented documentation indicating how to exclude
Pipfile.lockfrom thepretty-format-jsonhook.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jsf9k
changed the title
Pipfile.lock from pretty-format-json pre-commit hookexclude for Pipfile.lock to the pretty-format-json pre-commit hook
mcdonnnj
approved these changes
Apr 7, 2026
Member
mcdonnnj
left a comment
mcdonnnj
left a comment
There was a problem hiding this comment.
Thanks for taking care of this!
github-project-automation
bot
moved this from Review in progress
to Reviewer approved
in Skeleton Maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds a commented-out
excludeto thepre-commitconfiguration to excludePipfile.lockfrom thepretty-format-jsonhook.💭 Motivation and context
This
excludedirective will be uncommented in multiple downstream repos that usepipenv. We simply letpipenvformat those files however it wants; we don't care about prettifying them since they are for the most part only read by machines.This also saves us some time and effort on Dependabot PRs that update the
Pipfile.lockfile since they should pass thepre-commitlinters without being reformatted.🧪 Testing
All automated tests pass.
✅ Pre-approval checklist