Update warning screen natives#1041
Open
freedy69 wants to merge 4 commits into
Open
Conversation
PsychoShock
suggested changes
Mar 27, 2024
PsychoShock
left a comment
PsychoShock
left a comment
Contributor
There was a problem hiding this comment.
Hello,
I have left some comments. This is great work, nice job.
Contributor
|
Can you squash everything btw please? :) |
Update warning screen natives Update SetWarningMessageWithHeader Documented params and description Add button list to SetWarningMessage Update IsWarningMessageActive_2 Update SetWarningMessageWithHeaderAndSubstringFlags Fix oversight in SetWarningMessageWithHeaderAndSubstringFlags update native name in example SET_WARNING_MESSAGE_WITH_ALERT documented everything regarding this native Update GetWarningScreenMessageTitleHash.md added that this native returns 0 if warning message isnt active Remove dead imgur link in SetWarningMessage Update SetWarningMessage.md Removed gist link and improved information about buttons to help make it easier for people to understand
Did some testing and this doesn't seem to be case
AvarianKnight
requested changes
Aug 2, 2024
AvarianKnight
added
the
needs validation
apologies, i was away from the community for a while
Collaborator
|
Can you rebase these changes onto the master branch? |
Contributor
Author
|
sure but how? i dont know github too well sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected names and documented all the parameters