refactor(core): replace unicode-emoji-json with native RGI_Emoji regex - #1100
Open
0x5267 wants to merge 2 commits into
Open
refactor(core): replace unicode-emoji-json with native RGI_Emoji regex#11000x5267 wants to merge 2 commits into
0x5267 wants to merge 2 commits into
Conversation
0x5267
marked this pull request as draft
March 12, 2026 19:15
Use the native /\p{RGI_Emoji}/v regex available since Node 20+ instead
of the manual codepoint ranges in cleanPlayerName and the unicode-emoji-json
library in discordHelpers. This removes a dependency while improving emoji
detection accuracy.
0x5267
force-pushed
the
refactor/native-emoji-regex
branch
from
March 12, 2026 19:17
ab43970 to
9598273
Compare
0x5267
marked this pull request as ready for review
March 12, 2026 19:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes a TODO from dev-notes.md under "After Node 22" - use
/^\p{RGI_Emoji}$/vto detect emojis and removeunicode-emoji-jsonfrom dependencies.