Skip to content

feat: 启用 SKILL_LEARNING 编译开关#347

Merged
claude-code-best merged 1 commit intoclaude-code-best:mainfrom
amDosion:feat/ssh-remote-v2
Apr 24, 2026
Merged

feat: 启用 SKILL_LEARNING 编译开关#347
claude-code-best merged 1 commit intoclaude-code-best:mainfrom
amDosion:feat/ssh-remote-v2

Conversation

@amDosion
Copy link
Copy Markdown
Collaborator

@amDosion amDosion commented Apr 24, 2026

Summary

  • SKILL_LEARNING 加入 DEFAULT_BUILD_FEATURES,构建产物中默认启用技能学习系统
  • 此前该功能仅在 dev 模式下可用(dev 模式默认启用所有 feature),构建产物中因缺少编译开关导致 Skill Learning 不显示

Test plan

  • bun run build 构建后验证 feature('SKILL_LEARNING') 返回 true
  • 构建产物中 /learn 命令可用

Summary by CodeRabbit

  • New Features
    • Skill learning is now enabled by default. This feature integrates seamlessly with skill search to provide a comprehensive platform for discovering and developing new skills. Users can explore, discover, and actively learn new professional competencies, enhancing their ability to grow and develop new capabilities.

将 SKILL_LEARNING 加入 DEFAULT_BUILD_FEATURES,
构建产物中默认启用技能学习系统。
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7c877f17-fc3f-41d2-b2f5-87b3be78a6ae

📥 Commits

Reviewing files that changed from the base of the PR and between eb833da and 9d35f98.

📒 Files selected for processing (1)
  • scripts/defines.ts

📝 Walkthrough

Walkthrough

The DEFAULT_BUILD_FEATURES constant in scripts/defines.ts is updated to include a new 'SKILL_LEARNING' feature flag. The associated comment is also updated to indicate that the skill capability now encompasses both skill search and learning functionality.

Changes

Cohort / File(s) Summary
Build Features Configuration
scripts/defines.ts
Added 'SKILL_LEARNING' flag to DEFAULT_BUILD_FEATURES constant; updated comment for 'EXPERIMENTAL_SKILL_SEARCH' to reflect dual skill search and learning capability.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A learning leap, so shiny and new,
Skill flags now dance in the feature queue,
From search to mastery, abilities bloom,
Building better features, dispelling the gloom! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: enabling the SKILL_LEARNING compile flag in the default build features.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude-code-best claude-code-best merged commit d09f363 into claude-code-best:main Apr 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants