Add topo/dtopo input roadmap to dev/design - #748
Conversation
Signed-off-by: Kyle Mandli <kyle.mandli@gmail.com> Assisted-by: claude claude-opus-5
PR Detailed Description -- Summarized by ClaudeWhy this is tracked rather than in
|
| ±180 seam gap | design decision; three specific questions written out |
| dtopo Fortran crop/wrap parity | mandli#15 |
| 1D preprocessing scope | opened by #745; needs a decision, not a default |
| build-flag hygiene | radial_flat hardcode; the ALL_LFLAGS question |
-DNETCDF / make new |
documented, with both rejected fixes recorded |
The seam-gap entry is the one worth reading: it explains why buffer cannot
close the hole (after #739 the buffer is applied, but clamped to the file's own
extent, and neither entry has data past its edge), so the next person does not
re-try tuning it.
§3 — the #740 correction on record. The topo0save bug in #742 was
initially believed to explain the missing tsunami. It does not: #740 coarsens
GEBCO 20× to 0.167° while dtopo_usgs100227.tt3 is 0.101° (read from the
file header), so the finer topo_for_dtopo grid outranks the topo entries and
is deformed regardless. Recorded so the theory is not re-tried.
§4 — how each claim was checked, including what was not: that parity
passes CI on a machine other than the author's, and the remote tests.
The CI correction in the second commit
The first version of §2.3 said CI selects only python and slow markers.
That is wrong — testing.yml also has a regression-tests job, and
slow-tests.yml has matrix regression/python jobs. Found while checking
whether parity's tests/regression/topo_crop/ suite would actually run in CI.
The conclusion was unaffected and still holds — git grep -l 1d_classic -- tests/ .github/ is empty, so no 1D example is built or run anywhere in CI —
but the supporting detail would have misled anyone auditing coverage, and it
mattered in the other direction too: regression is a first-class CI selector,
which is what #742's topo0save test and parity's topo_crop suite rely on.
The paragraph now carries a table of all five jobs with their marker strings
quoted verbatim from the workflow files, each checked against
grep -hoE '\-m "[^"]+"' .github/workflows/*.yml.
Verification
Documentation only, so the check is that the references are real. Each was
confirmed against the repositories at 2026-09-07:
a3ee4b27(Add fetch_remote_topo; deprecate read_netcdf; refactor etopotools #726 merge), the twomerge-baseancestry relations, parity's
12 commits.nbuf4 = topo_bufferoccurrence counts:master1, Topocrop_extent/ antimeridian: stop failing silently, and make the working paths reachable #739 2.Makefile.common:66/:84,examples/bouss/radial_flat/Makefile:76.dtopo_usgs100227.tt3dx = 1.01010101010104e-01from its header.- Complete dtopo crop/wrap parity with topo (ASCII + netCDF) in the Fortran reader mandli/geoclaw#15 open, with the title quoted.
- All five CI marker strings verbatim;
1d_classicabsent fromtests/and
.github/.
Signed-off-by: Kyle Mandli <kyle.mandli@gmail.com> Assisted-by: claude claude-opus-5
…admap Signed-off-by: Kyle Mandli <kyle.mandli@gmail.com> Assisted-by: claude claude-opus-5[1m]
Design document for tracking and future plans for the heavy redo of the input file formats, notably
topo,dtopoandmetinput.