metrics: disambiguate websocket receive disconnects#5547
Merged
clockwork-labs-bot merged 2 commits intoJul 17, 2026
Conversation
cloutiertyler
approved these changes
Jul 15, 2026
clockwork-labs-bot
enabled auto-merge
July 16, 2026 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds specific
ClientDisconnectCausevariants for each websocket receiveWsErrorvariant, and records those specific causes in the subscribe route instead of collapsing all receive failures intowebsocket_receive_error.The legacy
WebsocketReceiveErrorenum variant and metric label are retained, but the receive loop now emits the more specific labels.API and ABI breaking changes
This adds public Rust enum variants and new metric label values. Existing variants are retained.
Expected complexity level and risk
1
This is an observability-only change. Websocket control flow is unchanged.
Testing
cargo fmt --all -- --checkcargo test -p spacetimedb-core client_disconnect_cause_labels_are_uniquecargo test -p spacetimedb-client-api recv_loop_terminates_when_input_yields_err