Switch unused-dependency check from cargo-machete to cargo-shear#255
Merged
Conversation
cargo-machete only inspects each crate's own dependency tables, so it misses unused entries in the workspace root and has substring-based false negatives. cargo-shear works from the resolved dependency graph and catches both, including unused `[workspace.dependencies]`. Swap the tool in CI, AGENTS.md, and the ct_worker README, then clean up the dead deps shear surfaced. Also fixes a latent TOML bug where integration_tests' homepage, repository, and description keys sat inside the cargo-machete metadata table instead of [package].
lukevalenta
requested review from
a team,
bwesterb,
cjpatton,
lbaquerofierro and
mendess
as code owners
July 13, 2026 19:46
Contributor
Author
|
/bonk review |
lbaquerofierro
approved these changes
Jul 13, 2026
|
PR #255 – Switch unused‑dependency check from Summary of changes
Verification
Risks / Open items
Conclusion: The PR cleanly replaces the old tool, updates documentation, removes dead code, and passes all build, test, and lint steps. No further changes are required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo-machete only inspects each crate's own dependency tables, so it misses unused entries in the workspace root and has substring-based false negatives. cargo-shear works from the resolved dependency graph and catches both, including unused
[workspace.dependencies].Swap the tool in CI, AGENTS.md, and the ct_worker README, then clean up the dead deps shear surfaced.
Also fixes a latent TOML bug where integration_tests' homepage, repository, and description keys sat inside the cargo-machete metadata table instead of [package].