Skip to content

[IAM] deprecate account role api#32024

Open
robotdan wants to merge 14 commits into
cloudflare:productionfrom
robotdan:ddegroff/deprecate_account_role_api
Open

[IAM] deprecate account role api#32024
robotdan wants to merge 14 commits into
cloudflare:productionfrom
robotdan:ddegroff/deprecate_account_role_api

Conversation

@robotdan

@robotdan robotdan commented Jul 11, 2026

Copy link
Copy Markdown

Summary

Deprecate the Account Role API.
No EOL yet.
ACCT-12238

Documentation checklist

  • Is there a changelog entry (guidelines)? If you don't add one for something awesome and new (however small) — how will our customers find out? Changelogs are automatically posted to RSS feeds, the Discord, and X.
  • The change adheres to the documentation style guide.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

Comment thread src/content/release-notes/api-deprecations.yaml Outdated
Comment thread src/content/release-notes/api-deprecations.yaml Outdated
Comment thread src/content/release-notes/api-deprecations.yaml Outdated

@AdamBouhmad AdamBouhmad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Made some small comments, but otherwise LGTM

Co-authored-by: Adam Bouhmad <adbouhmad@gmail.com>
@robotdan
robotdan marked this pull request as ready for review July 11, 2026 00:17
@robotdan
robotdan requested a review from a team as a code owner July 11, 2026 00:17
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review

✅ No issues found in commit fa463a7.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

No code review issues found.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@robotdan

Copy link
Copy Markdown
Author

CR-819784033e41 · Invalid CSS calc expression

  • N/A. This looks to be an existing issue in the repo, or due to the agent reviewing changes from a rebase?

CR-b7390274715d · Case-insensitive search only lowercases query

  • N/A. This looks to be an existing issue in the repo, or due to the agent reviewing changes from a rebase?

CR-7752e64d977b · Content mismatch with PR title

  • N/A. This looks to be a comment from a previous change to the repo, perhaps due to the agent reviewing changes from a rebase?

CR-a4a459bb14fc · Conflicting Tailwind position utilities

  • N/A. This looks to be an existing issue in the repo, or due to the agent reviewing changes from a rebase?

@robotdan
robotdan requested a review from a team as a code owner July 14, 2026 23:35
@KaydeeDee

Copy link
Copy Markdown
Contributor

This should be on https://developers.cloudflare.com/fundamentals/api/reference/deprecations/ for folks to reference the deprecation

@robotdan

Copy link
Copy Markdown
Author

This should be on https://developers.cloudflare.com/fundamentals/api/reference/deprecations/ for folks to reference the deprecation

Thanks @KaydeeDee!

I think the change I have in src/content/release-notes/api-deprecations.yaml‎ will end up on the deprecations page under fundamentals once built. I have confirmed with a local build. But let me know if I missed something!

Separately, still waiting on some internal copy review.

@AdamBouhmad AdamBouhmad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks daniel

@AdamBouhmad
AdamBouhmad enabled auto-merge (squash) July 17, 2026 20:25
@AdamBouhmad
AdamBouhmad requested a review from jhutchings1 July 20, 2026 20:30
Comment thread src/content/changelog/fundamentals/2026-07-21-account-role-api-deprecated.mdx Outdated
Comment thread src/content/release-notes/api-deprecations.yaml
@jhutchings1
jhutchings1 disabled auto-merge July 20, 2026 20:55
@jhutchings1

Copy link
Copy Markdown
Contributor

Disabled auto-merge to allow time to resolve the comments. Overall, seems fine and I don't mind approving in advance.

@jhutchings1 jhutchings1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with pending comments

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
Comment thread src/content/changelog/fundamentals/2026-07-21-account-role-api-deprecated.mdx Outdated
Comment thread src/content/changelog/fundamentals/2026-07-21-account-role-api-deprecated.mdx Outdated

The [Account Roles API](/api/resources/accounts/subresources/roles/) only returns account-level roles today, and is deprecated in favor of the [Permission Groups API](/api/resources/iam/subresources/permission_groups/). The Permission Groups API is the supported way to enumerate account, zone, and resource-level roles that can be granted to account members.

Deprecated APIs:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also mention the affected terraform resource: cloudflare_account_role and that users are expected to use the new cloudflare_account_permission_group resource.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this so the "Additional notes" below. If you prefer I add it as a top level section - happy to do that as well. But there was no prior art in this file for a top level terraform mention alongside the API, so I kept it as a note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants