[IAM] deprecate account role api#32024
Conversation
AdamBouhmad
left a comment
There was a problem hiding this comment.
Looks great! Made some small comments, but otherwise LGTM
Co-authored-by: Adam Bouhmad <adbouhmad@gmail.com>
Review✅ No issues found in commit Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
|
CR-819784033e41 · Invalid CSS calc expression
CR-b7390274715d · Case-insensitive search only lowercases query
CR-7752e64d977b · Content mismatch with PR title
CR-a4a459bb14fc · Conflicting Tailwind position utilities
|
|
This should be on https://developers.cloudflare.com/fundamentals/api/reference/deprecations/ for folks to reference the deprecation |
Thanks @KaydeeDee! I think the change I have in src/content/release-notes/api-deprecations.yaml will end up on the deprecations page under Separately, still waiting on some internal copy review. |
AdamBouhmad
left a comment
There was a problem hiding this comment.
LGTM. thanks daniel
|
Disabled auto-merge to allow time to resolve the comments. Overall, seems fine and I don't mind approving in advance. |
jhutchings1
left a comment
There was a problem hiding this comment.
Approve with pending comments
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
|
|
||
| The [Account Roles API](/api/resources/accounts/subresources/roles/) only returns account-level roles today, and is deprecated in favor of the [Permission Groups API](/api/resources/iam/subresources/permission_groups/). The Permission Groups API is the supported way to enumerate account, zone, and resource-level roles that can be granted to account members. | ||
|
|
||
| Deprecated APIs: |
There was a problem hiding this comment.
We should also mention the affected terraform resource: cloudflare_account_role and that users are expected to use the new cloudflare_account_permission_group resource.
There was a problem hiding this comment.
I added this so the "Additional notes" below. If you prefer I add it as a top level section - happy to do that as well. But there was no prior art in this file for a top level terraform mention alongside the API, so I kept it as a note.
Summary
Deprecate the Account Role API.
No EOL yet.
ACCT-12238
Documentation checklist