Skip to content

[Spectrum] Document IP Access Rules blocking health checks#32137

Open
stechedo wants to merge 1 commit into
cloudflare:productionfrom
stechedo:spectrum-ip-access-health-checks
Open

[Spectrum] Document IP Access Rules blocking health checks#32137
stechedo wants to merge 1 commit into
cloudflare:productionfrom
stechedo:spectrum-ip-access-health-checks

Conversation

@stechedo

Copy link
Copy Markdown
Collaborator

Summary

Split out of #30683 at the reviewer's request — see this comment:

Could we just hold the IP Access Rules + health checks section? I need a bit more time to verify the mechanism, but I don't want to block everything else.

Changes

  • spectrum/reference/troubleshooting.mdx — New "Health checks fail when IP Access Rules are enabled" section (symptoms/cause/solution) covering the allowlist-model blocking Cloudflare's health check probes.
  • spectrum/reference/configuration-options.mdx — Caution callout under IP Access rules warning about health check impact, plus a note that Custom Rules (WAF) do not apply to TCP/UDP Spectrum applications.
  • load-balancing/additional-options/spectrum.mdx — Matching caution callout in the Monitors step of the Spectrum load balancing setup guide.

Content area

Spectrum, Load Balancing

Split out from cloudflare#30683 per reviewer request to allow more time to
verify the allowlist/health-check mechanism.

- Add troubleshooting section for health checks failing when IP
  Access Rules use an allowlist model
- Add caution + note callouts in configuration-options.mdx
- Add caution callout in the Load Balancing Spectrum setup guide
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning found in commit 72a155a.

Fix in your agent
Fix the following review findings in PR #32137 (https://github.com/cloudflare/cloudflare-docs/pull/32137).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.

---

## Code Review

### Warnings (1)

#### CR-589005d5775b · Technically misleading alternative
- **File:** `src/content/docs/spectrum/reference/troubleshooting.mdx` line 47
- **Issue:** The added paragraph suggests using a TCP health check type as an alternative to allowlisting Cloudflare IPs. Because IP Access Rules evaluate every incoming connection to the Spectrum application, switching the health check protocol from HTTP to TCP does not bypass the block; the TCP connection from a blocked Cloudflare health check probe will still be rejected.
- **Fix:** Clarify that the alternative requires removing or changing IP Access Rules, and that moving access control to the origin is what allows health checks to succeed—not changing the health check type. If IP Access Rules remain enabled with an allowlist, any health check type must still allow Cloudflare’s probe IPs.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Warnings (1)
File Issue
spectrum/reference/troubleshooting.mdx line 47 Technically misleading alternative — The added paragraph suggests using a TCP health check type as an alternative to allowlisting Cloudflare IPs. Because IP Access Rules evaluate every incoming connection to the Spectrum application, switching the health check protocol from HTTP to TCP does not bypass the block; the TCP connection from a blocked Cloudflare health check probe will still be rejected. Fix: Clarify that the alternative requires removing or changing IP Access Rules, and that moving access control to the origin is what allows health checks to succeed—not changing the health check type. If IP Access Rules remain enabled with an allowlist, any health check type must still allow Cloudflare’s probe IPs.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.

@github-actions github-actions Bot added product:load-balancing Related to Load Balancing product product:spectrum Related to Spectrum product size/s labels Jul 17, 2026
stechedo added a commit to stechedo/cloudflare-docs that referenced this pull request Jul 17, 2026
…split health checks

Per review feedback on cloudflare#30683:

- Move the 'Health checks fail when IP Access Rules are enabled'
  section and related callouts to a separate PR (cloudflare#32137) so this PR
  isn't blocked while the mechanism is verified.
- Clarify that the DNS record conflict is specifically between a
  manually-created proxied record and a Spectrum application, not
  between Spectrum applications themselves. Multiple Spectrum
  applications (including a mix of HTTP/HTTPS and TCP/UDP) can share
  a hostname because Spectrum manages the DNS record for each.
- Align the double-proxy caution in configuration-options.mdx with
  the troubleshooting page: TCP applications surface a failed origin
  TLS handshake as 521/522, not error 525, which is HTTP/HTTPS-app
  specific.
stechedo added a commit to stechedo/cloudflare-docs that referenced this pull request Jul 17, 2026
…split health checks

Per review feedback on cloudflare#30683:

- Move the 'Health checks fail when IP Access Rules are enabled'
  section and related callouts to a separate PR (cloudflare#32137) so this PR
  isn't blocked while the mechanism is verified.
- Clarify that the DNS record conflict is specifically between a
  manually-created proxied record and a Spectrum application, not
  between Spectrum applications themselves. Multiple Spectrum
  applications (including a mix of HTTP/HTTPS and TCP/UDP) can share
  a hostname because Spectrum manages the DNS record for each.
- Align the double-proxy caution in configuration-options.mdx with
  the troubleshooting page: TCP applications surface a failed origin
  TLS handshake as 521/522, not error 525, which is HTTP/HTTPS-app
  specific.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:load-balancing Related to Load Balancing product product:spectrum Related to Spectrum product size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants