fix: update /rebase command copy and outdated PR check hint#32174
Conversation
Review💡 1 suggestion found in commit Fix in your agentFix the following review findings in PR #32174 (https://github.com/cloudflare/cloudflare-docs/pull/32174).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.
---
## Code Review
### Suggestions (1)
#### CR-f1d16bfae59b · Unreachable status branch updated
- **File:** `.flue/lib/code-review-render.ts` line 652
- **Issue:** The `halted-conflict` status message was changed, but the rebase workflow never emits `halted-conflict`; it only uses `halted-confidence`, `halted-wrong-base`, `halted-fork`, `complete`, `failed`, and `in-progress`. Updating this string changes dead code.
- **Fix:** Remove the `halted-conflict` case from `rebaseStatusLine` and drop `"halted-conflict"` from the `RebaseStatus` union if it will no longer be produced.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Suggestions (1)
ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Nimbus Preview URL: https://nimbus-a32acc76.preview.developers.cloudflare.com |
|
CR-f1d16bfae59b — already fixed. |
|
Preview URL: https://a32acc76.preview.developers.cloudflare.com |
Summary
Follow-up to #32121. Two copy fixes:
/rebaseand/rebaseWithConflictsrows into a single/rebaserow that describes the unified behavior (tries AI resolution on conflict)/rebaseon the PR to fix." to the failure descriptions in bothoutdated-pr-check.ymlandoutdated-pr-refresh.ymlDocumentation checklist