Skip to content

Trim leading whitespace from problems#1882

Merged
prymitive merged 1 commit into
mainfrom
problems
Jun 11, 2026
Merged

Trim leading whitespace from problems#1882
prymitive merged 1 commit into
mainfrom
problems

Conversation

@prymitive

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.85.0-29-g561fa444
Number of rules parsed 9
Number of rules checked 9
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (91ec950) to head (561fa44).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1882   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines        14955     14969   +14     
=========================================
+ Hits         14955     14969   +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
                             │   old.txt    │               new.txt               │
                             │    sec/op    │    sec/op     vs base               │
GlobFinder                      40.11m ± 1%   39.81m ±  1%        ~ (p=0.093 n=6)
GitFinder                       536.5m ± 2%   536.4m ±  0%        ~ (p=0.818 n=6)
Check/alerts/for                150.0µ ± 2%   147.5µ ±  1%   -1.71% (p=0.041 n=6)
Check/alerts/template           243.1m ± 2%   236.9m ±  1%   -2.56% (p=0.002 n=6)
Check/rule/dependency           24.23m ± 2%   23.34m ±  1%   -3.68% (p=0.002 n=6)
Check/alerts/external_labels    49.78m ± 0%   53.48m ±  1%   +7.42% (p=0.002 n=6)
Check/alerts/absent             89.83µ ± 1%   78.79µ ±  1%  -12.29% (p=0.002 n=6)
Check/promql/features          111.66µ ± 0%   97.32µ ±  1%  -12.84% (p=0.002 n=6)
Check/alerts/comparison         72.63µ ± 0%   62.00µ ±  1%  -14.64% (p=0.002 n=6)
Check/promql/nan                2.418m ± 1%   2.440m ±  1%   +0.88% (p=0.026 n=6)
Check/promql/series              1.095 ± 5%    1.073 ±  7%        ~ (p=0.310 n=6)
Check/promql/offset             3.249m ± 1%   3.320m ±  1%   +2.21% (p=0.009 n=6)
Check/labels/conflict           2.146m ± 1%   2.113m ±  1%   -1.52% (p=0.004 n=6)
Check/promql/counter            3.159m ± 3%   3.040m ±  1%   -3.78% (p=0.002 n=6)
Check/alerts/count              14.05m ± 9%   14.12m ± 10%        ~ (p=0.818 n=6)
Check/promql/regexp             1.445m ± 2%   1.368m ±  0%   -5.29% (p=0.002 n=6)
Check/promql/rate               5.567m ± 2%   5.225m ±  0%   -6.16% (p=0.002 n=6)
Check/promql/vector_matching    20.39m ± 3%   19.75m ±  1%   -3.14% (p=0.015 n=6)
Check/rule/reject               167.1µ ± 1%   167.7µ ±  1%   +0.36% (p=0.041 n=6)
Check/alerts/annotation         491.5µ ± 0%   478.6µ ±  1%   -2.63% (p=0.002 n=6)
Check/promql/syntax             15.97µ ± 2%   15.95µ ±  0%        ~ (p=0.093 n=6)
Check/promql/fragile            115.2µ ± 1%   102.0µ ±  1%  -11.44% (p=0.002 n=6)
Check/promql/impossible        108.56µ ± 0%   97.78µ ±  0%   -9.93% (p=0.002 n=6)
Check/group/interval            4.777µ ± 0%   4.782µ ±  2%        ~ (p=0.732 n=6)
Check/promql/range_query        3.272m ± 2%   3.275m ±  3%        ~ (p=0.699 n=6)
Check/rule/duplicate            18.27m ± 2%   18.23m ±  2%        ~ (p=0.394 n=6)
Check/rule/label                1.433m ± 4%   1.361m ±  1%   -4.99% (p=0.004 n=6)
Check/query/cost                22.47m ± 2%   22.37m ±  2%        ~ (p=0.180 n=6)
RuleIsIdentical                 19.73m ± 2%   19.93m ±  2%        ~ (p=0.394 n=6)
GetChecksForEntry               288.5m ± 1%   285.4m ±  3%        ~ (p=0.310 n=6)
geomean                         2.906m        2.817m         -3.08%

                             │    old.txt     │               new.txt                │
                             │      B/op      │     B/op      vs base                │
GlobFinder                     12.77Mi ± 0%     12.77Mi ± 0%       ~ (p=0.905 n=6)
GitFinder                      25.89Mi ± 0%     25.89Mi ± 0%       ~ (p=0.556 n=6)
Check/alerts/for               88.41Ki ± 0%     88.41Ki ± 0%       ~ (p=1.000 n=6) ¹
Check/alerts/template          112.4Mi ± 0%     112.4Mi ± 0%       ~ (p=0.535 n=6)
Check/rule/dependency          15.90Mi ± 0%     15.90Mi ± 0%       ~ (p=1.000 n=6) ¹
Check/alerts/external_labels   18.58Mi ± 0%     18.58Mi ± 0%  -0.00% (p=0.002 n=6)
Check/alerts/absent            3.812Ki ± 0%     3.812Ki ± 0%       ~ (p=1.000 n=6)
Check/promql/features            0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Check/alerts/comparison          352.0 ± 0%       352.0 ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/nan               191.6Ki ± 0%     191.6Ki ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/series            98.53Mi ± 0%     98.53Mi ± 0%       ~ (p=0.405 n=6)
Check/promql/offset            418.5Ki ± 0%     418.5Ki ± 0%       ~ (p=1.000 n=6)
Check/labels/conflict          275.8Ki ± 0%     275.8Ki ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/counter           454.8Ki ± 0%     454.8Ki ± 0%  +0.00% (p=0.002 n=6)
Check/alerts/count             1.508Mi ± 3%     1.508Mi ± 3%       ~ (p=0.784 n=6)
Check/promql/regexp            477.6Ki ± 0%     477.6Ki ± 0%  +0.00% (p=0.013 n=6)
Check/promql/rate              379.1Ki ± 0%     379.1Ki ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/vector_matching   8.181Mi ± 0%     8.181Mi ± 0%       ~ (p=1.000 n=6)
Check/rule/reject                0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Check/alerts/annotation          0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/syntax              0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/fragile           15.50Ki ± 0%     15.50Ki ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/impossible          704.0 ± 0%       704.0 ± 0%       ~ (p=1.000 n=6) ¹
Check/group/interval             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/range_query       418.0Ki ± 0%     418.0Ki ± 0%       ~ (p=1.000 n=6)
Check/rule/duplicate             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Check/rule/label               685.7Ki ± 0%     685.7Ki ± 0%  +0.00% (p=0.002 n=6)
Check/query/cost               525.0Ki ± 0%     525.0Ki ± 0%       ~ (p=1.000 n=6)
RuleIsIdentical                  0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GetChecksForEntry              99.93Mi ± 0%     99.93Mi ± 0%  +0.00% (p=0.004 n=6)
geomean                                     ²                 +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                             │    old.txt    │               new.txt               │
                             │   allocs/op   │  allocs/op   vs base                │
GlobFinder                     197.8k ± 0%     197.8k ± 0%       ~ (p=1.000 n=6)
GitFinder                      243.4k ± 0%     243.4k ± 0%       ~ (p=0.706 n=6)
Check/alerts/for               1.476k ± 0%     1.476k ± 0%       ~ (p=1.000 n=6) ¹
Check/alerts/template          1.046M ± 0%     1.046M ± 0%       ~ (p=0.182 n=6)
Check/rule/dependency          7.632k ± 0%     7.632k ± 0%       ~ (p=1.000 n=6) ¹
Check/alerts/external_labels   321.8k ± 0%     321.8k ± 0%  -0.00% (p=0.002 n=6)
Check/alerts/absent             76.00 ± 0%      76.00 ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/features           0.000 ± 0%      0.000 ± 0%       ~ (p=1.000 n=6) ¹
Check/alerts/comparison         4.000 ± 0%      4.000 ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/nan               3.652k ± 0%     3.652k ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/series            1.418M ± 0%     1.418M ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/offset            12.42k ± 0%     12.42k ± 0%       ~ (p=1.000 n=6) ¹
Check/labels/conflict          5.724k ± 0%     5.724k ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/counter           24.14k ± 0%     24.14k ± 0%       ~ (p=1.000 n=6) ¹
Check/alerts/count             34.14k ± 2%     34.14k ± 2%       ~ (p=1.000 n=6)
Check/promql/regexp            8.587k ± 0%     8.587k ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/rate              8.202k ± 0%     8.202k ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/vector_matching   90.51k ± 0%     90.51k ± 0%       ~ (p=0.892 n=6)
Check/rule/reject               0.000 ± 0%      0.000 ± 0%       ~ (p=1.000 n=6) ¹
Check/alerts/annotation         0.000 ± 0%      0.000 ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/syntax             0.000 ± 0%      0.000 ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/fragile            246.0 ± 0%      246.0 ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/impossible         5.000 ± 0%      5.000 ± 0%       ~ (p=1.000 n=6) ¹
Check/group/interval            0.000 ± 0%      0.000 ± 0%       ~ (p=1.000 n=6) ¹
Check/promql/range_query       12.41k ± 0%     12.41k ± 0%       ~ (p=1.000 n=6) ¹
Check/rule/duplicate            0.000 ± 0%      0.000 ± 0%       ~ (p=1.000 n=6) ¹
Check/rule/label               11.45k ± 0%     11.45k ± 0%       ~ (p=1.000 n=6) ¹
Check/query/cost               7.624k ± 0%     7.624k ± 0%       ~ (p=1.000 n=6) ¹
RuleIsIdentical                 0.000 ± 0%      0.000 ± 0%       ~ (p=1.000 n=6) ¹
GetChecksForEntry              1.654M ± 0%     1.654M ± 0%       ~ (p=0.545 n=6)
geomean                                    ²                -0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/cloudflare/pint/internal/diags
                           │   old.txt   │              new.txt              │
                           │   sec/op    │   sec/op     vs base              │
InjectDiagnosticsLongExpr    8.328µ ± 0%   8.493µ ± 3%  +1.99% (p=0.002 n=6)
InjectDiagnosticsShortExpr   1.275µ ± 0%   1.297µ ± 0%  +1.73% (p=0.002 n=6)
geomean                      3.258µ        3.318µ       +1.86%

                           │   old.txt    │               new.txt                │
                           │     B/op     │     B/op      vs base                │
InjectDiagnosticsLongExpr    3.578Ki ± 0%   3.578Ki ± 0%       ~ (p=1.000 n=6) ¹
InjectDiagnosticsShortExpr     304.0 ± 0%     304.0 ± 0%       ~ (p=1.000 n=6) ¹
geomean                      1.031Ki        1.031Ki       +0.00%
¹ all samples are equal

                           │  old.txt   │              new.txt               │
                           │ allocs/op  │ allocs/op   vs base                │
InjectDiagnosticsLongExpr    39.00 ± 0%   39.00 ± 0%       ~ (p=1.000 n=6) ¹
InjectDiagnosticsShortExpr   13.00 ± 0%   13.00 ± 0%       ~ (p=1.000 n=6) ¹
geomean                      22.52        22.52       +0.00%
¹ all samples are equal

pkg: github.com/cloudflare/pint/internal/parser
      │   old.txt   │           new.txt            │
      │   sec/op    │   sec/op     vs base         │
Parse   19.27m ± 2%   19.49m ± 2%  ~ (p=0.180 n=6)

      │   old.txt    │            new.txt            │
      │     B/op     │     B/op      vs base         │
Parse   6.385Mi ± 0%   6.385Mi ± 0%  ~ (p=0.558 n=6)

      │   old.txt   │           new.txt            │
      │  allocs/op  │  allocs/op   vs base         │
Parse   102.8k ± 0%   102.8k ± 0%  ~ (p=1.000 n=6)

pkg: github.com/cloudflare/pint/internal/parser/source
             │   old.txt   │              new.txt              │
             │   sec/op    │   sec/op     vs base              │
LabelsSource   1.089m ± 0%   1.102m ± 1%  +1.17% (p=0.002 n=6)

             │   old.txt    │            new.txt            │
             │     B/op     │     B/op      vs base         │
LabelsSource   755.0Ki ± 0%   755.0Ki ± 0%  ~ (p=0.660 n=6)

             │   old.txt   │            new.txt             │
             │  allocs/op  │  allocs/op   vs base           │
LabelsSource   7.251k ± 0%   7.251k ± 0%  ~ (p=1.000 n=6) ¹
¹ all samples are equal

pkg: github.com/cloudflare/pint/internal/promapi
                  │   old.txt   │              new.txt              │
                  │   sec/op    │   sec/op     vs base              │
QueryCacheOnlySet   113.1n ± 0%   113.3n ± 0%  +0.18% (p=0.037 n=6)

                  │  old.txt   │            new.txt            │
                  │    B/op    │    B/op     vs base           │
QueryCacheOnlySet   64.00 ± 0%   64.00 ± 0%  ~ (p=1.000 n=6) ¹
¹ all samples are equal

                  │  old.txt   │            new.txt            │
                  │ allocs/op  │ allocs/op   vs base           │
QueryCacheOnlySet   1.000 ± 0%   1.000 ± 0%  ~ (p=1.000 n=6) ¹
¹ all samples are equal

@prymitive prymitive merged commit bd2bd16 into main Jun 11, 2026
20 checks passed
@prymitive prymitive deleted the problems branch June 11, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants