Skip to content

test(css): css module compatibility issue and workaround verification - #3000

Open
NriotHrreion wants to merge 4 commits into
cloudflare:mainfrom
NriotHrreion:feat/issue-2992-vite-css-modules
Open

test(css): css module compatibility issue and workaround verification#3000
NriotHrreion wants to merge 4 commits into
cloudflare:mainfrom
NriotHrreion:feat/issue-2992-vite-css-modules

Conversation

@NriotHrreion

@NriotHrreion NriotHrreion commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

See #2992

Overview

see #2992 (comment)

There are some css module compatibility issues between postcss and vite, which has been solved by a vite plugin https://github.com/privatenumber/vite-css-modules. For vinext, we need to verify the vite-css-modules plugin could resolve the compatibility issue completely, and recommend users to install vite-css-modules plugin during vinext init.

What changed

  • Add fixture
  • Add test to assert failure
  • Verify the effect of vite-css-modules

Verification

  • Fixtures: css-module-compatibility and css-module-compatibility-fixed
  • pnpm test tests/css-module-compatibility.test.ts

@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vinext/cloudflare@3000
npm i https://pkg.pr.new/create-vinext-app@3000
npm i https://pkg.pr.new/@vinext/types@3000
npm i https://pkg.pr.new/vinext@3000

commit: 834e46c

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared 834e46c against base 52c81f3 using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 141.4 KB 141.4 KB ⚫ +0.0%
Client entry size (gzip) vinext 128.8 KB 128.8 KB ⚫ 0.0%
Dev server cold start vinext 3.14 s 3.11 s ⚫ -1.0%
Production build time vinext 3.49 s 3.49 s ⚫ +0.1%
RSC entry closure size (gzip) vinext 115.6 KB 115.6 KB ⚫ +0.0%
Server bundle size (gzip) vinext 196.8 KB 196.8 KB ⚫ +0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@NriotHrreion
NriotHrreion marked this pull request as ready for review August 19, 2026 14:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e397350718

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/css-module-compatibility.test.ts
@NriotHrreion NriotHrreion changed the title test(css): css module compatibility issue validation and workaround test(css): css module compatibility issue and workaround validation Aug 19, 2026
@NriotHrreion NriotHrreion changed the title test(css): css module compatibility issue and workaround validation test(css): css module compatibility issue and workaround verification Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant