Skip to content

fix(cloudflare): default CDN warmup concurrency to 25 #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
james-elicx merged 1 commit into from
Aug 24, 2026
Merged

fix(cloudflare): default CDN warmup concurrency to 25 #3015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/cloudflare/src/cdn-warm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export type CdnWarmOptions = {
fetchImpl?: typeof fetch;
};

export const DEFAULT_CDN_WARM_CONCURRENCY = 25;
export const DEFAULT_CDN_WARM_TIMEOUT_MS = 10_000;

export type PrerenderCdnWarmOptions = Omit<CdnWarmOptions, "paths"> & {
Expand Down Expand Up @@ -571,7 +572,7 @@ export async function warmCdnCache(options: CdnWarmOptions): Promise<CdnWarmResu
// policy. Once those gates pass, fill the remaining independent cache keys
// concurrently. Propagation is bounded by the retry count, never by a
// queue-wide wall-clock deadline that can expire before work starts.
const concurrency = Math.max(1, options.concurrency ?? 10);
const concurrency = Math.max(1, options.concurrency ?? DEFAULT_CDN_WARM_CONCURRENCY);
const normalRetries = Math.max(0, options.retries ?? 1);
const propagationRetries = Math.max(0, options.retries ?? 30);
const normalRetryDelayMs = Math.max(0, options.retryDelayMs ?? 0);
Expand Down
2 changes: 1 addition & 1 deletion packages/cloudflare/src/deploy-help.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function formatDeployHelp(): string {
Upload a Worker version, warm build-discovered paths
through the production URL, then promote it (experimental)
--warm-cdn-concurrency <count>
Maximum number of CDN warmup requests in parallel
Maximum number of CDN warmup requests in parallel (default: 25)
--warm-cdn-timeout <ms> Per-request CDN warmup timeout (default: 10000)
--warm-cdn-retries <n> Retries for transient CDN warmup failures (default: 1)
--warm-cdn-strict Fail deploy when any CDN warmup request fails
Expand Down
4 changes: 3 additions & 1 deletion tests/cloudflare-cdn-warm.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import os from "node:os";
import path from "node:path";
import {
buildWarmupUrl,
DEFAULT_CDN_WARM_CONCURRENCY,
DEFAULT_CDN_WARM_TIMEOUT_MS,
readPrerenderWarmPlan,
warmCdnCache,
Expand Down Expand Up @@ -62,7 +63,8 @@ afterEach(() => {
});

describe("Cloudflare CDN warmup", () => {
it("uses a 10 second default timeout and preserves query strings", () => {
it("uses the documented warmup defaults and preserves query strings", () => {
expect(DEFAULT_CDN_WARM_CONCURRENCY).toBe(25);
expect(DEFAULT_CDN_WARM_TIMEOUT_MS).toBe(10_000);
expect(buildWarmupUrl("https://app.example.com", "/search?q=x").href).toBe(
"https://app.example.com/search?q=x",
Expand Down
Loading