Skip to content

fix(cloudflare): handle non-cacheable warm paths safely - #3043

Closed
james-elicx wants to merge 1 commit into
codex/rsc-prewarm-no-promote-completefrom
codex/rsc-prewarm-discovery-response-safety
Closed

fix(cloudflare): handle non-cacheable warm paths safely#3043
james-elicx wants to merge 1 commit into
codex/rsc-prewarm-no-promote-completefrom
codex/rsc-prewarm-discovery-response-safety

Conversation

@james-elicx

Copy link
Copy Markdown
Member

Summary

  • skip same-build 307/404 responses only when Cloudflare and response policy explicitly prove they are non-cacheable
  • continue failing non-success responses from an unexpected build or without cache opt-out evidence
  • validate the complete Pages getStaticPaths result instead of silently emitting a partial warm manifest

Next.js reference

Pages result validation follows packages/next/src/build/static-paths/pages.ts: the result must be an object containing only an array paths and a boolean or blocking fallback.

Scope

This is a focused cumulative-review follow-up for RSC/ISR CDN warm discovery and validation. It does not alter route rendering, middleware, dev mode, or general cache behavior.

Validation

  • 60 focused warm/discovery tests passed
  • targeted format, lint, and type checks passed

@pkg-pr-new

pkg-pr-new Bot commented Aug 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vinext/cloudflare@3043
npm i https://pkg.pr.new/create-vinext-app@3043
npm i https://pkg.pr.new/@vinext/types@3043
npm i https://pkg.pr.new/vinext@3043

commit: 5e4f9aa

@github-actions

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared 5e4f9aa against base ff55d3f using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.2 KB 142.2 KB ⚫ +0.0%
Client entry size (gzip) vinext 129.5 KB 129.5 KB ⚫ +0.0%
Dev server cold start vinext 2.38 s 2.36 s ⚫ -1.0%
Production build time vinext 2.64 s 2.62 s ⚫ -0.7%
RSC entry closure size (gzip) vinext 116.0 KB 116.0 KB ⚫ +0.0%
Server bundle size (gzip) vinext 197.5 KB 197.5 KB ⚫ +0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@james-elicx

Copy link
Copy Markdown
Member Author

Superseded by consolidated PR #3046. No commits were dropped or rewritten: #3046 now contains this exact linear commit as part of #3041#3046. Closing only the redundant draft PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant