Skip to content

fix(cloudflare): enforce no-promote CDN warmup contract - #3045

Closed
james-elicx wants to merge 1 commit into
codex/rsc-prewarm-app-html-prooffrom
codex/rsc-prewarm-no-promote-contract
Closed

fix(cloudflare): enforce no-promote CDN warmup contract#3045
james-elicx wants to merge 1 commit into
codex/rsc-prewarm-app-html-prooffrom
codex/rsc-prewarm-no-promote-contract

Conversation

@james-elicx

Copy link
Copy Markdown
Member

Summary

  • reject --warm-cdn-no-promote when discovery finds no requests instead of silently running an ordinary deployment
  • reject no-promote HTML warming before upload when the adapter cannot verify response build identity
  • preserve normal best-effort promotion behavior when no-promote is not requested

Scope

This is a narrow exact-head review follow-up for the CDN prewarming promotion-control flag. It does not change cache admission, routing, middleware, or general deployment behavior.

Validation

  • 39 focused deploy tests passed
  • targeted format, lint, and type checks passed

@pkg-pr-new

pkg-pr-new Bot commented Aug 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vinext/cloudflare@3045
npm i https://pkg.pr.new/create-vinext-app@3045
npm i https://pkg.pr.new/@vinext/types@3045
npm i https://pkg.pr.new/vinext@3045

commit: d7794d6

@github-actions

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
workers-cache preview production
web preview production

@github-actions

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared d7794d6 against base 697f59a using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.2 KB 142.2 KB ⚫ +0.0%
Client entry size (gzip) vinext 129.5 KB 129.5 KB ⚫ +0.0%
Dev server cold start vinext 3.18 s 3.18 s ⚫ +0.0%
Production build time vinext 3.65 s 3.64 s ⚫ -0.1%
RSC entry closure size (gzip) vinext 116.0 KB 116.0 KB ⚫ -0.0%
Server bundle size (gzip) vinext 197.5 KB 197.5 KB ⚫ +0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@james-elicx

Copy link
Copy Markdown
Member Author

Superseded by consolidated PR #3046. No commits were dropped or rewritten: #3046 now contains this exact linear commit as part of #3041#3046. Closing only the redundant draft PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant