Skip to content

fix(build): exclude route handlers from CDN warm paths - #3048

Closed
james-elicx wants to merge 1 commit into
codex/rsc-prewarm-static-params-validationfrom
codex/rsc-prewarm-page-ownership
Closed

fix(build): exclude route handlers from CDN warm paths#3048
james-elicx wants to merge 1 commit into
codex/rsc-prewarm-static-params-validationfrom
codex/rsc-prewarm-page-ownership

Conversation

@james-elicx

Copy link
Copy Markdown
Member

Summary

  • apply runtime App/Pages ownership resolution to HTML warm paths as well as RSC paths
  • exclude concrete App candidates shadowed by App route handlers or Pages API routes
  • retain independently discovered Pages page keys and App page keys in original discovery order

Scope

This changes only which build-discovered page URLs are sent to CDN warmup. It does not change runtime route priority or handler behavior.

Validation

  • 45 focused discovery/deploy-wiring tests passed
  • targeted format, lint, and type checks passed

@pkg-pr-new

pkg-pr-new Bot commented Aug 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vinext/cloudflare@3048
npm i https://pkg.pr.new/create-vinext-app@3048
npm i https://pkg.pr.new/@vinext/types@3048
npm i https://pkg.pr.new/vinext@3048

commit: 414c6a1

@github-actions

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
workers-cache preview production
web preview production

@github-actions

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared 414c6a1 against base 34d2ecc using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.2 KB 142.2 KB ⚫ 0.0%
Client entry size (gzip) vinext 129.5 KB 129.5 KB ⚫ 0.0%
Dev server cold start vinext 3.17 s 3.15 s ⚫ -0.7%
Production build time vinext 3.60 s 3.57 s ⚫ -0.8%
RSC entry closure size (gzip) vinext 116.1 KB 116.1 KB ⚫ +0.0%
Server bundle size (gzip) vinext 197.6 KB 197.6 KB ⚫ +0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@james-elicx

Copy link
Copy Markdown
Member Author

Superseded by consolidated PR #3057. No commits were dropped or rewritten: #3057 now contains this exact linear commit as part of #3047#3057. Closing only the redundant draft PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant