Skip to content

fix(build): preserve exact CDN warm path identity - #3050

Closed
james-elicx wants to merge 1 commit into
codex/rsc-prewarm-union-ownershipfrom
codex/rsc-prewarm-path-identity-validation
Closed

fix(build): preserve exact CDN warm path identity#3050
james-elicx wants to merge 1 commit into
codex/rsc-prewarm-union-ownershipfrom
codex/rsc-prewarm-path-identity-validation

Conversation

@james-elicx

Copy link
Copy Markdown
Member

Summary

  • reject relative, double-slash, query-bearing, and fragment-bearing getStaticPaths strings instead of normalizing them into a different warm key
  • preserve the exact spelling of explicit locale prefixes because Workers cache keys are case-sensitive
  • require App generateStaticParams entries to be plain parameter objects before combining them with parent params

Next.js reference

This follows the string route-regex and plain-object checks in Next.js packages/next/src/build/static-paths/pages.ts and app.ts.

Scope

This only validates and preserves build-discovered CDN warm request paths. Runtime routing and ordinary application requests are unchanged.

Validation

  • 57 focused discovery/endpoint tests passed
  • targeted format, lint, and type checks passed

@pkg-pr-new

pkg-pr-new Bot commented Aug 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vinext/cloudflare@3050
npm i https://pkg.pr.new/create-vinext-app@3050
npm i https://pkg.pr.new/@vinext/types@3050
npm i https://pkg.pr.new/vinext@3050

commit: 9d3d6dd

@github-actions

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
workers-cache preview production
web preview production

@github-actions

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared 9d3d6dd against base 25e23c9 using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.2 KB 142.2 KB ⚫ -0.0%
Client entry size (gzip) vinext 129.5 KB 129.5 KB ⚫ -0.0%
Dev server cold start vinext 3.19 s 3.19 s ⚫ +0.0%
Production build time vinext 3.64 s 3.66 s ⚫ +0.7%
RSC entry closure size (gzip) vinext 116.1 KB 116.1 KB ⚫ +0.0%
Server bundle size (gzip) vinext 197.6 KB 197.6 KB ⚫ +0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@james-elicx

Copy link
Copy Markdown
Member Author

Superseded by consolidated PR #3057. No commits were dropped or rewritten: #3057 now contains this exact linear commit as part of #3047#3057. Closing only the redundant draft PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant