fix(metrics): make port configurable#755
Open
chomatdam wants to merge 1 commit intocloudnative-pg:mainfrom
Open
fix(metrics): make port configurable#755chomatdam wants to merge 1 commit intocloudnative-pg:mainfrom
chomatdam wants to merge 1 commit intocloudnative-pg:mainfrom
Conversation
chomatdam
requested review from
fcanovai,
gbartolini,
itay-grudev,
leonardoce,
mnencia,
phisco and
sxd
as code owners
dosubot
bot
added
size:S
Signed-off-by: Damien Chomat <damien.chomat@gmail.com>
chomatdam
force-pushed
the
damien/metrics-port
branch
from
f252a6f to
7013c4b
Compare
gbartolini
added
the
chart( operator )
Author
|
let me know if there is anything I can do to help this PR getting merged, otherwise I'll just wait your backlog gets to it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the Prometheus metrics port configurable in the cloudnative-pg Helm chart (instead of being hardcoded to 8080).