Skip to content

feat: report bad urls in policies #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dudymas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: report bad urls in policies #154

dudymas wants to merge 1 commit into from

Conversation

@dudymas
Copy link
Contributor

@dudymas dudymas commented Aug 25, 2023

what

  • report a url that doesn't fetch with a 2XX status code

why

  • helps with debugging upgrades when policies are missing

@dudymas dudymas requested review from a team as code owners August 25, 2023 21:45
@dudymas dudymas requested review from Gowiem and korenyoni August 25, 2023 21:45
@milldr
Copy link
Member

milldr commented Aug 25, 2023

/terratest

2 similar comments
@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@Gowiem
Copy link
Member

Gowiem commented Mar 4, 2024

Huh this is a weird terratest failure:

+ PATH_TO_TERRAFORM=/usr/local/terraform//bin
+ '[' -x /usr/local/terraform//bin/terraform ']'
+ echo 'Unable to locate executable for terraform '
Unable to locate executable for terraform 
+ exit 1
Error: Process completed with exit code 1.

Will rerun with TF 1.0

@Gowiem Gowiem added terraform/1.0 enhancement New feature or request minor New features that do not break anything labels Mar 4, 2024
@Gowiem
Copy link
Member

Gowiem commented Mar 4, 2024

/terratest

@settings settings bot removed the terraform/1.0 label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request minor New features that do not break anything

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dudymas @milldr @hans-d @Gowiem