fix: prevent list item jump on hover in virtual scrolling (v2)

[mxschll]

Note: This PR supersedes PR#3943 and includes an additional fix. The original implementation used globalIndex for the position offset calculation, which caused whitespace issues when scrolling through large lists:

// ./src/select/utils/render-options.tsx
const adjustedVirtualPosition = virtualItem ? virtualItem.start - globalIndex : undefined;

Changed to use index (virtual window position) instead of globalIndex (absolute list position) to correctly calculate the 1px overlap offset:

// ./src/select/utils/render-options.tsx
const adjustedVirtualPosition = virtualItem ? virtualItem.start - index : undefined;

Description

With virtual scrolling enabled, selectable items would "jump" on hover/selection due to border width changes (AWSUI-61303). Virtual scrolling positions items absolutely, so when border width changes from 1px to 2px on hover, the browser recalculates layout dimensions causing visible position shifts.

Additionally, option groups were missing the separating top border.

Before	After

The solution uses box-shadows when virtual scrolling is enabled to simulate thick borders while maintaining thin actual borders. An alternative solution of making all borders the same thickness (hover / non-hover) would change the visual appearance compared to how it's supposed to look.

In summary:

• Eliminates jumping behavior with virtual scrolling enabled
• Maintains visual consistency with non-virtual scrolling
• Adds top separator to option groups

How has this been tested?

Changes ran through screenshot test and have been verified locally.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

• Changes include appropriate documentation updates.
• Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
• Changes do not include unsupported browser features, see CONTRIBUTING.md.
• Changes were manually tested for accessibility, see accessibility guidelines.

Security

• If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

• Changes are covered with new/existing unit tests?
• Changes are covered with new/existing integration tests?

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.14%. Comparing base (8b1948a) to head (3b628c4).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4064   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files         869      869           
  Lines       25473    25489   +16     
  Branches     9209     9215    +6     
=======================================
+ Hits        24745    24761   +16     
  Misses        681      681           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[SpyZzey]

The changes still have two bugs. In the Autosuggest, select-all still shifts when hovering.
https://d21d5uik3ws71m.cloudfront.net/components/c8deadcd58165722038f814907d79a25e8edca8f/dev-pages-react18/index.html#/light/multiselect/select-all/?virtualScroll=true&closeAfter=false

Also, the checkbox in multiselect is shifting slightly when selecting:
https://d21d5uik3ws71m.cloudfront.net/components/c8deadcd58165722038f814907d79a25e8edca8f/dev-pages-react18/index.html#/light/multiselect/screenshot

[mxschll]

The changes still have two bugs. In the Autosuggest, select-all still shifts when hovering. https://d21d5uik3ws71m.cloudfront.net/components/c8deadcd58165722038f814907d79a25e8edca8f/dev-pages-react18/index.html#/light/multiselect/select-all/?virtualScroll=true&closeAfter=false

Also, the checkbox in multiselect is shifting slightly when selecting: https://d21d5uik3ws71m.cloudfront.net/components/c8deadcd58165722038f814907d79a25e8edca8f/dev-pages-react18/index.html#/light/multiselect/screenshot

Addressed in new revision.

[pan-kot]

why do we repeat styles from the non-sticky items?

[mxschll]

We apply these styles to virtual elements, but sticky elements aren't virtual. Perhaps it would be better to merge .virtual and .sticky, but the linter didn't like my first approach. I'll try a different one…

[pan-kot]

would it be possible to create a few simple mixins in this file so to share the common styles between sticky and virtual?