Skip to content

fix: correct redirect targets for 13 @antv/x6 packages#292

Open
elrrrrrrr wants to merge 1 commit into
masterfrom
x6
Open

fix: correct redirect targets for 13 @antv/x6 packages#292
elrrrrrrr wants to merge 1 commit into
masterfrom
x6

Conversation

@elrrrrrrr
Copy link
Copy Markdown
Member

@elrrrrrrr elrrrrrrr commented May 19, 2026

Summary

Follow-up to #291. That PR shipped the antv-block incident list for 317 packages and used the literal string "3.0.0" as the placeholder redirect target for 13 of the @antv/x6-* entries whose canonical last-clean version was not resolved at ingest time. There is no 3.0.0 release on those lines, so the redirects were inert. This PR replaces each placeholder with the actual last clean version published before the 2026-05-19 block date, matching the wording already in the per-entry reason field.

Changes

26 leaf version values across 13 top-level keys in config['bug-versions']. The blocked-version keys (the inner JSON keys) and the reason strings are untouched; only the leaf "version" moves. Diff is symmetric — 26 insertions and 26 deletions, no other bytes changed, no new top-level keys, no new sub-version keys.

Package Blocked versions New target
@antv/x6-common 2.1.17, 2.2.17 2.0.17
@antv/x6-geometry 2.1.5, 2.2.5 2.0.5
@antv/x6-plugin-dnd 2.2.1, 2.3.1 2.1.1
@antv/x6-plugin-export 2.2.6, 2.3.6 2.1.6
@antv/x6-plugin-history 2.3.4, 2.4.4 2.2.4
@antv/x6-plugin-keyboard 2.3.3, 2.4.3 2.2.3
@antv/x6-plugin-minimap 2.1.7, 2.2.7 2.0.7
@antv/x6-plugin-scroller 2.1.10, 2.2.10 2.0.10
@antv/x6-plugin-selection 2.3.2, 2.4.2 2.2.2
@antv/x6-plugin-snapline 2.2.7, 2.3.7 2.1.7
@antv/x6-plugin-stencil 2.2.5, 2.3.5 2.1.5
@antv/x6-plugin-transform 2.2.8, 2.3.8 2.1.8
@antv/x6-react-components 2.1.9, 2.2.9 2.0.9

The other @antv/x6-* entries from #291 (e.g. @antv/x6 itself, x6-angular-shape, x6-components, x6-react, x6-react-shape, x6-vector, x6-vue-shape, x6-vue3-shape, x6-plugin-clipboard) already have correct non-placeholder targets and are not touched.

Test plan

  • node --test test/index.test.js — passes locally (# Total: 497 bug pkgs and 923 bug versions, both subtests ok).
  • Schema invariant per the test: every entry has a string version and a string reason.
  • No new top-level keys, no new inner version keys — the find-duplicated-property-keys CI check has the same input shape as feat: add antv-block incident block list for 317 packages #291 plus this 26-line value-only swap.
  • Trailing single newline on package.json preserved (}\n}\n at EOF, matching the pre-image).
  • CI: PR title check (@commitlint/config-angular) — the fix: prefix is in the allowed type list.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated version mappings for @antv/x6 packages and related plugins to ensure compatibility with stable release versions.

Review Change Stack

PR #291 wrote the placeholder string "3.0.0" as the redirect target
for 13 @antv/x6-* packages whose canonical last-clean version was not
resolved at ingest time. This commit replaces each placeholder with
the actual last clean version published before the 2026-05-19 block
date, matching the wording already used in the per-entry reason field.

Updated entries (26 leaves across 13 top-level keys):

- @antv/x6-common           2.1.17, 2.2.17  -> 2.0.17
- @antv/x6-geometry         2.1.5,  2.2.5   -> 2.0.5
- @antv/x6-plugin-dnd       2.2.1,  2.3.1   -> 2.1.1
- @antv/x6-plugin-export    2.2.6,  2.3.6   -> 2.1.6
- @antv/x6-plugin-history   2.3.4,  2.4.4   -> 2.2.4
- @antv/x6-plugin-keyboard  2.3.3,  2.4.3   -> 2.2.3
- @antv/x6-plugin-minimap   2.1.7,  2.2.7   -> 2.0.7
- @antv/x6-plugin-scroller  2.1.10, 2.2.10  -> 2.0.10
- @antv/x6-plugin-selection 2.3.2,  2.4.2   -> 2.2.2
- @antv/x6-plugin-snapline  2.2.7,  2.3.7   -> 2.1.7
- @antv/x6-plugin-stencil   2.2.5,  2.3.5   -> 2.1.5
- @antv/x6-plugin-transform 2.2.8,  2.3.8   -> 2.1.8
- @antv/x6-react-components 2.1.9,  2.2.9   -> 2.0.9

The blocked-version keys and the reason strings are unchanged; only
the leaf "version" target moves. Verified with `node --test`
(497 packages / 923 versions, both schema subtests pass).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e426412a-2717-40b9-9c83-cbdd17837e33

📥 Commits

Reviewing files that changed from the base of the PR and between d93a77b and ec6c0d1.

📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

Updated bug-version configuration overrides in package.json for multiple @antv/x6-* packages, downgrading mapped versions from 3.0.0 to specific 2.0.x/2.1.x targets while preserving redirect reasons indicating a clean version before 2026-05-19.

Changes

AntV X6 Package Version Overrides

Layer / File(s) Summary
@antv/x6- version redirect configuration*
package.json
Version overrides for @antv/x6-common (→2.0.17), @antv/x6-geometry (→2.0.5), @antv/x6-plugin-* packages (→2.1.x variants), and @antv/x6-react-components (→2.0.9) updated from 3.0.0 targets with preserved reason text.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through versions neat,
From three-oh down to something sweet,
The plugins dance to X6's tune,
Redirected by the moon of June,
Clean versions bloom, antv's boon! 🌙

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: correct redirect targets for 13 @antv/x6 packages' directly and specifically summarizes the main change: correcting version redirect targets for 13 @antv/x6 packages in the config.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch x6

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package.json file to redirect various @antv/x6 packages and plugins to their last clean versions, replacing the "3.0.0" placeholder as part of a block-list configuration. A review comment identifies that @antv/x6-plugin-clipboard was likely omitted from these changes accidentally and should be updated to version 2.1.6 to maintain consistency with the other plugins.

Comment thread package.json
"@antv/x6-plugin-dnd": {
"2.2.1": {
"version": "3.0.0",
"version": "2.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PR description mentions that @antv/x6-plugin-clipboard already has a correct target and was not touched. However, checking lines 4224-4233 in the file, it still uses the "3.0.0" placeholder for versions 2.2.6 and 2.3.6. It seems this package was accidentally omitted from the fix, likely because it was incorrectly identified as already being correct. Based on the pattern for other plugins with identical blocked versions (like x6-plugin-export), the target should likely be 2.1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant