fix: refuse to start when JWT secret is shorter than 32 bytes - #413
Open
BetterAndBetterII wants to merge 1 commit into
Open
BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
Default deployments used a predictable short secret and only warned. Panic on weak secrets so admin JWTs cannot be forged offline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default deployments copy
secret: secretfrom the example config.ReadConfonly logged a warning and slept 10 seconds, then continued signing JWTs with that short key, so an attacker could forge an admin token offline (see #411).This change makes
ReadConfpanic when the configured secret is shorter than 32 bytes, instead of starting insecurely.Test plan
go test -vet=off ./utils -run TestValidateSecret -count=1secretstill startsFixes #411