cli: add ZSTD encoding support for tsdump generation and upload #161998
+138
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visheshbardia
requested review from
aa-joshi and
alyshanjahani-crl
and removed request for
a team
Member
|
This change is |
visheshbardia
force-pushed
the
tsdump-compression-zstd
branch
from
fd48ed3 to
37b2699
Compare
Contributor
arjunmahishi
left a comment
arjunmahishi
left a comment
There was a problem hiding this comment.
I think we might also have to make changes on the server side? to handle cases where tsdumps are staged on roachprod? @Abhinav1299 would know more
visheshbardia
force-pushed
the
tsdump-compression-zstd
branch
from
37b2699 to
7dc5d42
Compare
visheshbardia
changed the title
This change adds ZSTD encoding support to the tsdump command, eliminating the need for manual compression/decompression of tsdump files. - Added `--encoding=zstd` flag for raw format to generate ZSTD-compressed files. - Enabled `tsdump upload` to automatically detect and decompress ZSTD files. Fixes cockroachdb#151727 Epic: CRDB-56325 Part-of: CRDB-53445 Release note (cli change): The `cockroach debug tsdump` command now supports ZSTD encoding via `--format=raw --encoding=zstd`. This generates compressed tsdump files that are ~85% smaller than raw format. The `tsdump upload` command automatically detects and decompresses ZSTD files, allowing direct upload without manual decompression.
visheshbardia
force-pushed
the
tsdump-compression-zstd
branch
from
7dc5d42 to
c7cf4c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds native ZSTD encoding support to the tsdump command,
eliminating the need for manual compression/decompression of tsdump files.
--encoding=zstdflag for raw format to generate ZSTD-compressed files.tsdump uploadto automatically detect and decompress ZSTD files.Fixes #151727
Epic: CRDB-56325
Part-of: CRDB-53445
Release note (cli change): The
cockroach debug tsdumpcommand nowsupports ZSTD encoding via
--format=raw --encoding=zstd. This generatescompressed tsdump files that are ~85% smaller than raw format. The
tsdump uploadcommand automatically detects and decompresses ZSTDfiles, allowing direct upload without manual decompression.