Conversation
|
lorisleiva
left a comment
There was a problem hiding this comment.
Thanks, I've made some important comments but this is a solid base. I'll give it another thorough review after these are addressed.
lorisleiva
left a comment
There was a problem hiding this comment.
Thanks! Another round of comments. 🙏
lorisleiva
left a comment
There was a problem hiding this comment.
Nice, thank you! Just a quick nit and I think we're good to go.
Summary
I added this while making
dynamic-parserssupport full Anchor-format parsing, and I want to upstream the base event support first so that work can stay aligned withmain.This PR adds
EventNodesupport across the core packages and imports Anchoreventsinto the program AST.A follow-up change depends on this.
Changes
EventNodeto node types and node constructorsProgramNode.eventsdefinedTypeseventNodeValidation
pnpm lintpnpm test