-
Notifications
You must be signed in to change notification settings - Fork 10
feat: add max retry metrics to upload flow tasks and notify task #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add max retry metrics to upload flow tasks and notify task #580
Conversation
- Replace retry() calls with safe_retry() in UploadTask, UploadProcessorTask, UploadFinisherTask, and NotifyTask - Add proper error handling when max retries are exceeded - Update tests to mock safe_retry() instead of retry() - All tasks now track worker_task_counts_max_retries_exceeded metric This ensures consistent retry metric tracking across all upload flow tasks, matching the implementation from commit 427ec64.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
==========================================
- Coverage 93.85% 93.82% -0.04%
==========================================
Files 1284 1284
Lines 46443 46461 +18
Branches 1522 1522
==========================================
+ Hits 43590 43591 +1
- Misses 2543 2560 +17
Partials 310 310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
adrianviquez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does safe_retry do/how does it work as opposed to what we have today?
|
This ensures consistent retry metric tracking across all upload flow tasks,
matching the implementation from commit 427ec64.