Skip to content

Conversation

@drazisil-codecov
Copy link
Contributor

  • Replace retry() calls with safe_retry() in UploadTask, UploadProcessorTask, UploadFinisherTask, and NotifyTask
  • Add proper error handling when max retries are exceeded
  • Update tests to mock safe_retry() instead of retry()
  • All tasks now track worker_task_counts_max_retries_exceeded metric

This ensures consistent retry metric tracking across all upload flow tasks,
matching the implementation from commit 427ec64.

- Replace retry() calls with safe_retry() in UploadTask, UploadProcessorTask, UploadFinisherTask, and NotifyTask
- Add proper error handling when max retries are exceeded
- Update tests to mock safe_retry() instead of retry()
- All tasks now track worker_task_counts_max_retries_exceeded metric

This ensures consistent retry metric tracking across all upload flow tasks,
matching the implementation from commit 427ec64.
@codecov-eu
Copy link

codecov-eu bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 41.37931% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/worker/tasks/upload.py 25.00% 12 Missing ⚠️
apps/worker/tasks/notify.py 75.00% 2 Missing ⚠️
apps/worker/tasks/upload_finisher.py 33.33% 2 Missing ⚠️
apps/worker/tasks/upload_processor.py 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@sentry
Copy link

sentry bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 41.37931% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.82%. Comparing base (2a2ca6e) to head (60f9dcf).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/tasks/upload.py 25.00% 12 Missing ⚠️
apps/worker/tasks/notify.py 75.00% 2 Missing ⚠️
apps/worker/tasks/upload_finisher.py 33.33% 2 Missing ⚠️
apps/worker/tasks/upload_processor.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
- Coverage   93.85%   93.82%   -0.04%     
==========================================
  Files        1284     1284              
  Lines       46443    46461      +18     
  Branches     1522     1522              
==========================================
+ Hits        43590    43591       +1     
- Misses       2543     2560      +17     
  Partials      310      310              
Flag Coverage Δ
workerintegration 58.59% <3.44%> (-0.03%) ⬇️
workerunit 91.08% <37.93%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 41.37931% with 17 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/tasks/upload.py 25.00% 12 Missing ⚠️
apps/worker/tasks/notify.py 75.00% 2 Missing ⚠️
apps/worker/tasks/upload_finisher.py 33.33% 2 Missing ⚠️
apps/worker/tasks/upload_processor.py 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@drazisil-codecov drazisil-codecov requested a review from a team November 21, 2025 17:27
Copy link
Contributor

@adrianviquez adrianviquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does safe_retry do/how does it work as opposed to what we have today?

@drazisil-codecov
Copy link
Contributor Author

What does safe_retry do/how does it work as opposed to what we have today?

retry raises qn exception to be caught upstream by wrapper login, or tasks that might have custom exception handling.
safe_retry logs the retry metrics and doesn't throw an exception. It allows us to log the message when we don't need to throw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants