Repository navigation
Preserve Toolbox log original log location - #360
Merged
Merged
Conversation
Toolbox logger did a nifty trick in which methods like error, info, debug were inline methods. They managed to capture the business class from which it was called. Once we wrapped the Toolbox logger into our own CoderLogger, the log location always became the CoderLogger. So we did a similar thing. We inlined the session-aware logger methods so Toolbox attributes each entry to the business caller while keeping popup messages evaluated once.
code-asher
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolbox logger did a nifty trick in which methods like error, info, debug were inline methods. They managed to capture the business class from which it was called. Once we wrapped the Toolbox logger into our own CoderLogger, the log location always became the CoderLogger. So we did a similar thing.
We inlined the session-aware logger methods so Toolbox attributes each entry to the business caller while keeping popup messages evaluated once.