Skip to content

🤖 tests: sendModeDropdown 'send after step' waits only 1 s for the stream to start #5807

Description

@ThomasK33

tests/ui/chat/sendModeDropdown.test.ts › "send after step waits for every tool call emitted in the current step" failed in CI with "Expected the source turn to be streaming before queueing".

Likely cause (not proven): the waitFor for canInterrupt at sendModeDropdown.test.ts:207 sets no timeout, so it uses the testing-library default of 1000 ms. A sibling test waits for the same condition with { timeout: 30_000 } (around line 240). On a loaded runner the stream can take more than 1 s to start.

Fix idea: give that wait an explicit load-tolerant timeout, as the sibling test does.

The PR #5801 readiness check found that its changes cannot reach this path: the failing wait runs before any composer edit code, and the only send before it is a normal send.

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high • Cost: $33.65

Activity

  1. ThomasK33 commented on Oct 9, 2026

    @ThomasK33
    MemberAuthor

    One more occurrence, in the merge queue for #5949 (merge group on main 7d4497b85d): Test / Integration (1/3) failed with "Expected the source turn to be streaming before queueing" in "send after step waits for every tool call emitted in the current step". The same shard passed on the PR's own CI for head 3e8e40626312a496898017c27a3107f77432f8b4. #5949 changes only the empty-state text class in App.tsx and one aria-hidden in the onboarding wizard. I added it to the queue once more, without a push.


    Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high • Cost: $182.51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    approvedTriage: passed unanimous bug screenbacklog

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions