Skip to content

🤖 fix: Ollama schema rewrite follow-ups (draft-07 dependencies, DevTools recording) #6083

Description

@ThomasK33

Two small follow-ups from the clean-context review of #6080 (Ollama tool schemas: type arrays to anyOf).

  1. The rewrite does not recurse into draft-07 dependencies. A schema-valued dependencies entry that holds a type array still reaches old Ollama servers (< v0.6.6) as an array, so that request fails. Built-in tools do not use dependencies. Only an MCP schema could. Fix: add dependencies to the schema-map keywords (only its object values are schemas; array values are property lists).
  2. After the wrap, the Ollama model reports specificationVersion: "v4" (ollama-ai-provider-v2 reports "v3"). It now passes the v4 checks at providerModelFactory.ts (:1584) and turnRequestBuilder.ts (:3232), so DevTools records Ollama requests when it is on. That is harmless (the Copilot route already behaves this way), but nobody documented it. Confirm it is intended, or note it in the DevTools docs.

Trigger: an MCP server whose tool schema uses dependencies with a nullable type, a user report of a failing old-Ollama tool call, or the next change to this middleware.

Refs #6080, #6078, #6071.


Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high • Cost: $680.90

Activity

  1. self-assigned this
    on Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions