Repository navigation
🤖 feat: add a resolver for workspace model, thinking and reasoning picks - #5895
ibetitsmike wants to merge 3 commits into
Conversation
The resolver reads, per field, the unsent pick, the workspace's saved settings for the agent, the agent's configured defaults, then project and global defaults. Creation scopes keep their own scoped defaults in both the hook and the plain reader. Workspace metadata loads (desktop and webview) now feed its store, but nothing reads the resolver yet. Stack-Layer: A2a
…late Merges the updated layer below. Stack-Layer: A2a
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a97db95b3f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The resolver treated every id starting with "__" as a creation scope, so a legacy `<project basename>-<branch>` workspace read creation defaults instead of its saved settings. Only the global, project, pending and draft scopes count as creation scopes. Stack-Layer: A2a
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86e280c72b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Adds the renderer resolver that the next layers switch to:
getWorkspaceAiSelection(plain reader) anduseWorkspaceAiSelection(hook) inworkspaceAiSettingsSync.ts. For a workspace and agent it resolves each field from, in order, the unsent pick, the workspace's saved settings for that agent (aiSettingsByAgent, falling back toaiSettings), the agent's configured defaults, then the project default and the global default. A saved per-agent entry owns the reasoning mode, so an entry without one means standard. Creation composers (the reserved global, project, pending and draft scope IDs,isNonWorkspaceScopeId) keep resolving from their own project, global or draft defaults, in both readers; a legacy workspace whose ID starts with__resolves as a workspace.The pick store in
aiSelectionIntent.tsgains what the resolver needs: a per-workspace copy of the AI metadata (setWorkspaceAiMetadata, fed by metadata loads in the desktop app and the VS Code webview), a reader for one pending pick, change notifications for the hook, anddropPendingModelPicksfor provider removal. Nothing reads the resolver yet, so no behavior changes.Stack
Milestone M4 of the server-side settings stack, on top of M3 (#5869 to #5879): per-workspace AI picks (model, thinking level, reasoning mode, agent and Auto routing) are stored in workspace metadata in
config.jsoninstead of per-browser localStorage keys, so every browser shows the same picks. An unsent picker change stays in memory in its tab until a send saves it, and a reload before sending drops it, as the plan accepts. Layer 2 of 20.Testing
workspaceAiSettingsSync.test.ts): each tier, including an unsent reasoning pick, wins over the ones below it for model, thinking level and reasoning mode.__<project>-<branch>workspace reads its saved settings, not creation defaults.WorkspaceContext.test.tsxalso checks that a non-archived metadata event reaches the resolver's store.make static-checkand the touched test suites pass at the top of the stack; CI checks each layer on its own.Review record
efe7e29096, because a fork without a message dropped the source's unsent picks (fixed by 🤖 feat: fork a workspace with the source composer's unsent AI picks #5897, 🤖 refactor: resolve the workspace agent from metadata and an unsent pick #5908 and 🤖 refactor: resolve auto routing from the unsent pick, saved flags and agent defaults #5909); everything else passed. Round 2: PASS on80f2b5379e: forks from all five entry points keep the unsent picks, startup removes the retired keys, and the round 1 checks still pass; the plan handoff was not exercised because the mock model cannot propose a plan. The Codex round 1 fixes made since then have no remote UAT yet; that is left to the next UAT round on 🤖 refactor: keep preferences and workspace AI picks on the server #5916.a97db95b3f: 2 findings: 1 fixed in 86e280c, 1 declined with the reason in its thread. Mike asked to land the stack as one PR, so further review runs on 🤖 refactor: keep preferences and workspace AI picks on the server #5916.