Skip to content

馃 tests: delete the WorkspaceModeAISync model key checks #5902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ibetitsmike wants to merge 6 commits into from
Closed

馃 tests: delete the WorkspaceModeAISync model key checks #5902

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
428f035
test: delete the WorkspaceModeAISync model key checks
ibetitsmike Oct 8, 2026
b77d119
Merge the updated layer below into the A2c4 layer
ibetitsmike Oct 8, 2026
3ed09ca
Merge the updated layer below into the A2c4 layer
ibetitsmike Oct 8, 2026
e0703a7
Merge the updated layer below into the A2c4 layer
ibetitsmike Oct 8, 2026
c017959
Merge the updated layer below into the A2c4 layer
ibetitsmike Oct 8, 2026
2930369
Merge the updated layer below into the A2c4 layer
ibetitsmike Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions src/browser/components/WorkspaceModeAISync/WorkspaceModeAISync.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
getAgentIdKey,
getAutoModelRoutingKey,
getAutoThinkingLevelKey,
getModelKey,
getThinkingLevelKey,
getWorkspaceAISettingsByAgentKey,
} from "@/common/constants/storage";
Expand Down Expand Up @@ -130,7 +129,6 @@ describe("WorkspaceModeAISync", () => {
exec: { modelString: "openai:gpt-5.2", thinkingLevel: "high" },
plan: { modelString: "openai:gpt-5.2", thinkingLevel: "high" },
});
updatePersistedState(getModelKey(workspaceId), "openai:gpt-5.2");
updatePersistedState(getThinkingLevelKey(workspaceId), "high");
updatePersistedState(getAutoModelRoutingKey(workspaceId), true);
updatePersistedState(getAutoThinkingLevelKey(workspaceId), true);
Expand Down Expand Up @@ -163,21 +161,18 @@ describe("WorkspaceModeAISync", () => {
exec: { model: workspaceModel, thinkingLevel: workspaceThinking },
});

updatePersistedState(getModelKey(workspaceId), "some-legacy-model");
updatePersistedState(getThinkingLevelKey(workspaceId), "medium");

renderSync({ workspaceId, agentId: "exec" });

await waitFor(() => {
expect(readPersistedState(getModelKey(workspaceId), "")).toBe("some-legacy-model");
expect(readPersistedState(getThinkingLevelKey(workspaceId), "high")).toBe("medium");
});
});

test("ignores workspace-by-agent values when settings are inherit", async () => {
const workspaceId = nextWorkspaceId();

const existingModel = "some-legacy-model";
const existingThinking = "off";

// Inherit in Settings removes explicit per-agent defaults from agentAiDefaults.
Expand All @@ -186,13 +181,11 @@ describe("WorkspaceModeAISync", () => {
exec: { model: "openai:gpt-5.2", thinkingLevel: "medium" },
});

updatePersistedState(getModelKey(workspaceId), existingModel);
updatePersistedState(getThinkingLevelKey(workspaceId), existingThinking);

renderSync({ workspaceId, agentId: "exec" });

await waitFor(() => {
expect(readPersistedState(getModelKey(workspaceId), "")).toBe(existingModel);
expect(readPersistedState(getThinkingLevelKey(workspaceId), "off")).toBe(existingThinking);
});
});
Expand Down Expand Up @@ -228,7 +221,6 @@ describe("WorkspaceModeAISync", () => {
test("ignores same-agent workspace overrides when agent defaults are missing", async () => {
const workspaceId = nextWorkspaceId();

const existingModel = "some-legacy-model";
const existingThinking = "high";

setTestAgentAiDefaults({
Expand All @@ -238,57 +230,15 @@ describe("WorkspaceModeAISync", () => {
custom: { model: "openai:gpt-5.2-pro", thinkingLevel: "medium" },
});

updatePersistedState(getModelKey(workspaceId), existingModel);
updatePersistedState(getThinkingLevelKey(workspaceId), existingThinking);

renderSync({ workspaceId, agentId: "custom" });

await waitFor(() => {
expect(readPersistedState(getModelKey(workspaceId), "")).toBe(existingModel);
expect(readPersistedState(getThinkingLevelKey(workspaceId), "off")).toBe(existingThinking);
});
});

test("keeps the user's model when per-agent settings change without an agent switch", async () => {
const workspaceId = nextWorkspaceId();

const configuredModel = "anthropic:claude-haiku-4-5";
const userModel = "anthropic:claude-sonnet-4-5";

setTestAgentAiDefaults({
exec: { modelString: configuredModel },
});
updatePersistedState(getModelKey(workspaceId), configuredModel);
updatePersistedState(getThinkingLevelKey(workspaceId), "off");

renderSync({ workspaceId, agentId: "exec" });

await waitFor(() => {
expect(readPersistedState(getModelKey(workspaceId), "")).toBe(configuredModel);
});

// Picking a model writes both the model key and the per-agent settings cache.
act(() => {
updatePersistedState(getModelKey(workspaceId), userModel);
updatePersistedState(getWorkspaceAISettingsByAgentKey(workspaceId), {
exec: { model: userModel, thinkingLevel: "off" },
});
});

expect(readPersistedState(getModelKey(workspaceId), "")).toBe(userModel);

// Changing the thinking level rewrites the same per-agent cache entry.
act(() => {
updatePersistedState(getThinkingLevelKey(workspaceId), "high");
updatePersistedState(getWorkspaceAISettingsByAgentKey(workspaceId), {
exec: { model: userModel, thinkingLevel: "high" },
});
});

expect(readPersistedState(getModelKey(workspaceId), "")).toBe(userModel);
expect(readPersistedState(getThinkingLevelKey(workspaceId), "")).toBe("high");
});

test("does not inherit base defaults when selected agent has its own partial settings entry", async () => {
const workspaceId = nextWorkspaceId();

Expand Down
Loading