Add datadog profiler in mongobetween#62
Draft
zachxu42 wants to merge 1 commit intocoinbase:masterfrom
Draft
Conversation
kounat
reviewed
Jun 17, 2024
Comment on lines
+48
to
+50
| VersionName: v.GetString("codeflow_release_id"), | ||
| ProjectName: v.GetString("codeflow.project_name"), | ||
| Environment: v.GetString("codeflow.config_name"), |
Contributor
There was a problem hiding this comment.
There's a ton of Coinbase-specific references here -- we're going to have to think about how to make it more flexible. Initial thoughts are to continue to leverage flags again or use S3.
edit: We might also be able to remove the import to spf13/viper, which is a huge plus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.