feat: Add MongoDB read preference support#92
Open
scmsscm wants to merge 1 commit intocoinbase:masterfrom
Open
Conversation
- Implement ReadPref() method for all operation types - Extract read preferences from wire protocol messages - Update selectServer to use client read preferences - Add comprehensive test suite (14 tests, all passing) - Maintain backward compatibility
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by https://github.com/coinbase/mongobetween/pull/76/files but rewritten from scratch with TDD.
Summary
Implements full MongoDB read preference support in mongobetween, allowing clients to specify which replica set members should handle read operations.
Motivation
Closes #76 (previous incomplete attempt)
Currently, mongobetween hardcodes read preference to
primaryfor all operations. This prevents applications from leveraging secondaries for read scaling.Changes
ReadPref()method toOperationinterface$readPreferencefield)selectServer()to accept and use client-specified read preferencesTesting
✅ 14 new unit tests covering all read preference modes and edge cases
✅ All tests passing
✅ Zero linter errors
✅ Build successful
Test output: