setup.php-dist __CA_APP_DIR__ not defined error fix#175
Open
zachjamesjohn wants to merge 1 commit into
Open
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
if (!defined("CA_LOG_DIR")) {
define("CA_LOG_DIR", CA_APP_DIR."/log");
}
from setup.php-dist
I believe it was mistakenly added in c09602c#diff-15cef81e15416052a091284b9f0b335e15777ee0597012d9f5c085a7320dc4b9
It was meant to be added back to post-setup.php
It was removed from post-setup.php in 6eaa091#diff-97c766ff6f2262b482ee6fe494021716ab97d1d03153d2dabfffc300e0eec88f
It was added back to post-setup.php in 047ba46