Repository navigation
fix: SET n = map reads n first; label tests in SET values (GQLITE-T-0479) - #203
Merged
Merged
Conversation
…479)
SET n = {id: n.id, ...} cleared n and then dropped the computed id: bulk
SET stores only literal map values. A SET = map with computed values now
runs in the row pipeline, which computes the map for the row first, as
for +=. A SET value with a label test (CASE WHEN n:A ..., n:A) was left
to SET, which refused it: the row pipeline now computes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SET n = {id: n.id, q: 1}left n with{q: 1}: bulk SET cleared n, then dropped the map value it could not store (it stores only literal map values). ASET n = mapwith computed values now runs in the row pipeline, which computes the map for the row first, as+=already did (GQLITE-T-0479).CASE WHEN n:A THEN … END,n:A) was refused ("SET value must be a literal …"), with or without RETURN: the row pipeline did not know label tests were computable. It now computes them.Test plan
Semantic coverage matrix
Checklist