-
Notifications
You must be signed in to change notification settings - Fork 6
feat: don't show descriptions from non verbose search output #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
amoeba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. I'll let @zeroshade have a look before merging.
|
I think ideally we'd have the Is something like that possible given the data we have available in the driver index? |
|
I'm with you in the sense that I think we almost certainly want to display more info than what's proposed by this PR. Adding vendor strings like in your example isn't possible right this second but it's not too hard. My understanding is that the motivation for this change was to address @esadek's reaction to the current output, I won't speak for @esadek but, after taking some time away from it, I now notice the text isn't super scannable and "An ADBC driver for" is very redundant. I like that the descriptions are regular though which is how we got to the above output in the first place. We have at least two options to change this:
I think (2) is better than (1) because a verbose description is fine for each driver and the issue is how it presents when you show a big list of them. i.e., what dbc needs is not necessarily what a driver author needs. |
|
Regarding showing both short and full names, this still feels redundant to me. Most of the results would just be duplicates such as: In cases where it would not be just duplicate names, I think the short name is still sufficient. What do you guys think? |
|
If we do want to include the full name, maybe we append "driver"? |
|
@esadek I think you're correct right now that the short name is probably sufficient for most people to deduce what the database/engine/platform is, but as we add more over time, the short names will become increasingly unfamiliar and cryptic. I like the idea to add a field containing the full name in the driver index YAML, and then use that here, potentially with |
|
We can also play with colors here to make the output appear less duplicative at a glance. |
|
I think we're uncovering that our driver descriptions are themselves not information rich which is how we end up here. When we (soon) have two BigQuery drivers, what will we say about to help users pick between them? To focus purely on the visual side, how much would tab-stop aligning help? I noticed cargo does that. Our output could look like, $ dbc search
bigquery # Driver for Google BigQuery developed by the ADBC Driver Foundry
duckdb # Driver for DuckDB developed by the DuckDB Foundation
flightsql # Driver for Apache Arrow Flight SQL developed under the Apache Software Foundation
mssql # Driver for Microsoft SQL Server developed by Columnar
mysql # Driver for MySQL developed by the ADBC Driver Foundry
postgresql # Driver for PostgreSQL developed under the Apache Software Foundation
redshift # Driver for Amazon Redshift developed by Columnar
snowflake # Driver for Snowflake developed under the Apache Software Foundation
sqlite # Driver for SQLite developed under the Apache Software Foundation
trino # Driver for Trino developed by the ADBC Driver Foundryand we could also use colors for "Apache Software Foundation" and "ADBC Driver Foundry". Note I also removed "ADBC". |
zeroshade
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Remove driver descriptions from the
dbc search(non verbose) output.