Trivial changes#22
Merged
Merged
Conversation
I forgot to push this change a year ago.
The cfg is valid as it's intended to be passed manually to rustc. Fixes #21.
No actual code changes are necessary.
To be tagged and published to Cargo once merged. I don't think the changes really deserve individual changelog entries.
comex
force-pushed
the
trivial-changes
branch
3 times, most recently
from
5c2e676 to
7b1e624
Compare
- Stop using ATiltedTree/setup-rust@v1 because it apparently no longer exists. The runners have rustup installed by default, so use that. - Remove the separate `cargo check` job, since `cargo test` should be a superset of it. - Add a test on nightly with default features. - Add a test on MSRV (1.46) with default features. - Add `-Dwarnings` to all jobs so that the presence of any warnings causes the job to fail. For the MSRV job, this requires allowlisting an `unknown_lints` warning that's known to occur there. Note that newer Rust versions may cause existing code to start producing warnings, so there is no guarantee in general that this crate compiles without warnings. But it still makes sense to have this check in CI. If someone is making changes to this crate, they should fix any warnings that have cropped up. - Add a run of `cargo clippy` to the stable, stable-no-default-features, and nightly jobs. Probably not useful for MSRV. - Add a build of all fuzz targets to the stable and nightly jobs. Running them would probably be too expensive. - Fix a warning in one of the fuzz targets. - Update `fuzz/ Cargo.lock` (this happened automatically when I built the fuzz targets).
comex
force-pushed
the
trivial-changes
branch
from
7b1e624 to
2399e1e
Compare
Owner
Author
|
Added workflow changes. |
fenhl
reviewed
Mar 17, 2025
|
|
||
| test: | ||
| name: Test | ||
| nightly: |
Collaborator
There was a problem hiding this comment.
Do we really want to run CI on nightly Rust? That seems like it would have frequent errors caused by Rust itself. Might want to use Rust's beta channel instead.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Rustsec link in documentation.
I forgot to push this change a year ago.
Suppress unexpected_cfgs warning.
The cfg is valid as it's intended to be passed manually to rustc.
Fixes warning: unexpected
cfgcondition name:manual_codegen_check#21.Switch to 2018 edition to resolve warning recommending such.
No actual code changes are necessary.
Trivial changes suggested by clippy.
Change version number to 1.3.1 and update changelog.
To be tagged and published to Cargo once merged.
I don't think the changes really deserve individual changelog entries.
Update GitHub workflow.
Stop using ATiltedTree/setup-rust@v1 because it apparently no longer
exists. The runners have rustup installed by default, so use that.
Remove the separate
cargo checkjob, sincecargo testshouldbe a superset of it.
Add a test on nightly with default features.
Add a test on MSRV (1.46) with default features.
Add
-Dwarningsto all jobs so that the presence of any warningscauses the job to fail.
For the MSRV job, this requires allowlisting an
unknown_lintswarning that's known to occur there.
Note that newer Rust versions may cause existing code to start
producing warnings, so there is no guarantee in general that this
crate compiles without warnings. But it still makes sense to have
this check in CI. If someone is making changes to this crate, they
should fix any warnings that have cropped up.