Skip to content

Fix analyze mode enum ambiguity, normalize v1.1.0 invalid fixtures, and update checksum default#16

Merged
GsCommand merged 1 commit into
mainfrom
codex/fix-analyze.request.schema.json-mode-enum-ambiguity
Mar 20, 2026
Merged

Fix analyze mode enum ambiguity, normalize v1.1.0 invalid fixtures, and update checksum default#16
GsCommand merged 1 commit into
mainfrom
codex/fix-analyze.request.schema.json-mode-enum-ambiguity

Conversation

@GsCommand
Copy link
Copy Markdown
Contributor

Motivation

  • The analyze request schema exposed canonical verb names in the mode enum (e.g., classify) which creates semantic ambiguity between analysis style and verb delegation.
  • Many v1.1.0 invalid fixtures were copy-pasted and contained multiple simultaneous failures or wrong verb literals, reducing the suite's usefulness for targeted validation.
  • The generate-checksums.sh no-argument default used a stale schemas/v1.0.0 path, which silently limited checksum scope and diverged from the repo’s authoritative schemas/ layout.

Description

  • Replaced the verb-name classify mode with a non-ambiguous categorize value in schemas/v1.1.0/commons/analyze/analyze.request.schema.json and clarified the mode description to explain when to use dedicated verbs.
  • Updated TypeScript example surface to match the new enum (e.g., examples/v1.1.0/commons/analyze/ts/valid/analyze.request.valid.1.ts now uses "categorize").
  • Normalized the v1.1.0 invalid TypeScript request/receipt fixtures so each file now preserves the correct verb and isolates a single primary failure reason (many examples/v1.1.0/commons/*/ts/invalid/*.ts files updated).
  • Added one focused invalid JSON receipt to expand coverage for missing required top-level fields: examples/v1.1.0/commons/classify/json/invalid/902-missing-signature.receipt.invalid.json.
  • Changed scripts/generate-checksums.sh default root from schemas/v1.0.0 to schemas, added a short usage/help line, and regenerated checksums.txt to reflect the updated scope; explicit-argument behavior is preserved and package.json script still invokes bash scripts/generate-checksums.sh schemas checksums.txt.
  • Total touched files: 43 (schema, checksum script/output, updated TS invalid/valid examples, and one new invalid JSON fixture).

Testing

  • Ran node scripts/validate-all.mjs to compile schemas, which completed successfully.
  • Ran node scripts/validate-examples.mjs to validate example valid/invalid request and receipt fixtures, and all validations completed successfully with invalid fixtures still rejected and valid fixtures accepted.
  • Regenerated checksums with bash scripts/generate-checksums.sh schemas checksums.txt and verified the output updated checksums.txt as expected.
  • Verified no-arg invocation bash scripts/generate-checksums.sh now defaults to schemas and succeeds, and git diff --check returned no issues.

Codex Task

@GsCommand GsCommand merged commit b6c31e7 into main Mar 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant