Fix analyze mode enum ambiguity, normalize v1.1.0 invalid fixtures, and update checksum default#16
Merged
GsCommand merged 1 commit intoMar 20, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
analyzerequest schema exposed canonical verb names in themodeenum (e.g.,classify) which creates semantic ambiguity between analysis style and verb delegation.generate-checksums.shno-argument default used a staleschemas/v1.0.0path, which silently limited checksum scope and diverged from the repo’s authoritativeschemas/layout.Description
classifymode with a non-ambiguouscategorizevalue inschemas/v1.1.0/commons/analyze/analyze.request.schema.jsonand clarified the mode description to explain when to use dedicated verbs.examples/v1.1.0/commons/analyze/ts/valid/analyze.request.valid.1.tsnow uses"categorize").examples/v1.1.0/commons/*/ts/invalid/*.tsfiles updated).examples/v1.1.0/commons/classify/json/invalid/902-missing-signature.receipt.invalid.json.scripts/generate-checksums.shdefault root fromschemas/v1.0.0toschemas, added a short usage/help line, and regeneratedchecksums.txtto reflect the updated scope; explicit-argument behavior is preserved andpackage.jsonscript still invokesbash scripts/generate-checksums.sh schemas checksums.txt.Testing
node scripts/validate-all.mjsto compile schemas, which completed successfully.node scripts/validate-examples.mjsto validate example valid/invalid request and receipt fixtures, and all validations completed successfully with invalid fixtures still rejected and valid fixtures accepted.bash scripts/generate-checksums.sh schemas checksums.txtand verified the output updatedchecksums.txtas expected.bash scripts/generate-checksums.shnow defaults toschemasand succeeds, andgit diff --checkreturned no issues.Codex Task