feat: align runtime-core v1.1.0 protocol implementation#10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dist/) and provide CI to enforce typecheck/build/test on push/PR.Description
src/canonicalize.tsforjson.sorted_keys.v1, overhaulsrc/crypto.tsto exposePROTOCOL_VERSION,CANONICAL_METHOD,SIGNATURE_ALG,encodePublicKey,parsePublicKey,signCanonical,verifyCanonical,verifyCanonicalWithRawKey, andgenerateEd25519KeyPairusing standard base64 and raw UTF-8 signing.src/ens.tsto strictly resolve ENS text records and hard-fail on missing/malformed records, returning a typedEnsSignerRecordand convenienceresolvePublicKeyFromENSwrapper.src/receipt.tswith v1.1.0 layered receipt builder/verifier using proof fieldsalg,kid,signer_id,canonical, andsignature, plussignReceipt,verifyReceipt, andisSignedLayeredReceiptAPIs that validate structure and verification checks.src/index.ts, add test suites undertest/for canonicalize/crypto/receipt, add GitHub Actions CI workflow.github/workflows/ci.yml, and ensuredist/is untracked.Testing
bash DELETIONS.shto clear tracked build artifacts successfully.npm installbut it failed in this environment with a registry403 Forbiddenerror so dependencies were not installed.npm run buildandnpm run typecheckand both surfaced TypeScript errors in remaining project sources (missing/updated exports), so the compile/typecheck did not succeed.npm testbut it failed due to missing runtime test helper (tsx/esm) which could not be installed without a successfulnpm install, so the newly added tests were not executed here.Codex Task