fix runtime tests after canonical CLAS emitter migration#69
Merged
GsCommand merged 1 commit intoMay 18, 2026
Merged
Conversation
Why: runtime tests were failing after canonical emitter migration due incompatible runtime-core imports and verify response shape drift. Contract impact: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@commandlayer/runtime-coreimports and a drift in the/verifyresponse shape.metadata.proof.canonicalization,hash.{alg,value},signature.{alg,value,kid}) without reintroducing legacy top-level proof fields.Description
metadata.proof.hashandmetadata.proof.signature). (files:server.mjs)/verifyto compute the canonical hash, validate the Ed25519 signature againstmetadata.proof.signature.value, preserve theok/status/checks/errorscontract, and ensure tampered receipts returnok: falseandstatus: "INVALID". (files:server.mjs)hash_sha256from the primary/verifyresponse and exposedproof_hashinstead, and movedkidtoproof.signature.kidin API surfaces and responsevalues. (files:server.mjs)crypto.verifysemantics, and updated smoke test assertions to read the canonicalproof.signature.kid. (files:runtime/src/receipt-verification.js,tests/smoke.mjs)Testing
npm run check,npm test, andnpm run cilocally and all completed successfully in this environment.runtime/tests/runtime-signing.test.mjs,runtime/tests/receipt-verification.test.mjs,runtime/tests/key-rotation.test.mjs, andtests/smoke.mjsall pass after the fixes.server.mjs,runtime/src/receipt-verification.js,tests/smoke.mjsand commit SHAe0f6705376704d2336cec5e20157ac72d45e6d1a.runtime-corecanonical helper APIs change again, but behavior is preserved and covered by the repository's tests.Codex Task