[runtime] Restore runtime-core canonical receipt API ownership#70
Merged
Conversation
…ceipt proof construction and verification owned by runtime-core to prevent protocol drift from local canonical hash logic.\nContract impact: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
runtime-coreto eliminate protocol drift introduced by local primitive reimplementation.Description
CANONICAL_METHOD,signCommandLayerReceipt(), andverifyCommandLayerReceipt()imported from@commandlayer/runtime-core.computeCanonicalHash()implementation and its uses so canonical proof construction is no longer duplicated in the runtime.signature.alg = "Ed25519") and add a narrow verification adapter that normalizessignature.algtoed25519before callingverifyCommandLayerReceipt()to bridge a casing expectation gap.CANONICAL_ID_SORTED_KEYS_V1,signReceiptEd25519Sha256, orverifyReceiptEd25519Sha256.Testing
npm install,npm run check,npm test, andnpm run ci, and all completed successfully with unit and smoke tests passing.smoke ok.CANONICAL_METHODis sourced fromruntime-core,computeCanonicalHashwas removed, and signing/verification now delegate toruntime-corewith a minimal adapter for signature algorithm casing.Codex Task