fix: remove runtime Ed25519 casing adapter#71
Merged
Conversation
Why: runtime-core now emits and verifies "Ed25519" directly, so runtime should pass receipts unchanged to core verification. Contract impact: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
metadata.proof.signature.alg = "Ed25519"so the runtime-side lowercase adapter is no longer needed.@commandlayer/runtime-coreto avoid layer blurring.Description
@commandlayer/runtime-coredependency ref to8fcebeff72898ac1e3482f2d608b14769675f5e8inpackage.jsonandpackage-lock.json.metadata.proof.signature.algfromEd25519toed25519and now pass receipts unchanged toverifyCommandLayerReceipt(...)withallowedCanonicals: [runtimeConfig.canonicalMethod].CANONICAL_METHOD,signCommandLayerReceipt, andverifyCommandLayerReceipt, and did not reintroduce legacy helpers likeCANONICAL_ID_SORTED_KEYS_V1,signReceiptEd25519Sha256,verifyReceiptEd25519Sha256, or local canonical/hash helpers.package.json,package-lock.json, andserver.mjs(commitf1bb3c6).Testing
npm installwhich failed in this environment due to network/DNS resolution when fetching the git dependency from GitHub.npm run checkwhich succeeded (node --check server.mjs).npm testwhich executed unit tests and smoke tests and resulted in 3 failing tests related to/verifybehavior after removing the adapter:/verify accepts both wrapped and bare receipts from the production signing path,/verify?ens=1 passes with mocked ENS TXT response and preserves current kid behavior, andfull chain clean -> summarize -> classify verifies with schema using commons execution defaults.npm run ciwhich also failed because it runs the same test suite that produced the 3 failing tests.Codex Task