Skip to content

fix: remove runtime Ed25519 casing adapter#71

Merged
GsCommand merged 1 commit into
mainfrom
codex/update-runtime-to-new-core-commit
May 18, 2026
Merged

fix: remove runtime Ed25519 casing adapter#71
GsCommand merged 1 commit into
mainfrom
codex/update-runtime-to-new-core-commit

Conversation

@GsCommand
Copy link
Copy Markdown
Contributor

Motivation

  • runtime-core now emits and verifies metadata.proof.signature.alg = "Ed25519" so the runtime-side lowercase adapter is no longer needed.
  • Keep verification canonicalization and signing delegated to @commandlayer/runtime-core to avoid layer blurring.

Description

  • Updated @commandlayer/runtime-core dependency ref to 8fcebeff72898ac1e3482f2d608b14769675f5e8 in package.json and package-lock.json.
  • Removed the runtime-side adapter that mutated metadata.proof.signature.alg from Ed25519 to ed25519 and now pass receipts unchanged to verifyCommandLayerReceipt(...) with allowedCanonicals: [runtimeConfig.canonicalMethod].
  • Confirmed the runtime still imports and uses CANONICAL_METHOD, signCommandLayerReceipt, and verifyCommandLayerReceipt, and did not reintroduce legacy helpers like CANONICAL_ID_SORTED_KEYS_V1, signReceiptEd25519Sha256, verifyReceiptEd25519Sha256, or local canonical/hash helpers.
  • Files changed: package.json, package-lock.json, and server.mjs (commit f1bb3c6).

Testing

  • Ran npm install which failed in this environment due to network/DNS resolution when fetching the git dependency from GitHub.
  • Ran npm run check which succeeded (node --check server.mjs).
  • Ran npm test which executed unit tests and smoke tests and resulted in 3 failing tests related to /verify behavior after removing the adapter: /verify accepts both wrapped and bare receipts from the production signing path, /verify?ens=1 passes with mocked ENS TXT response and preserves current kid behavior, and full chain clean -> summarize -> classify verifies with schema using commons execution defaults.
  • Ran npm run ci which also failed because it runs the same test suite that produced the 3 failing tests.

Codex Task

Why: runtime-core now emits and verifies "Ed25519" directly, so runtime should pass receipts unchanged to core verification.

Contract impact: none
@GsCommand GsCommand merged commit ef51e96 into main May 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant