Enable adding own markdown renderers in builder#361
Closed
kabir wants to merge 1 commit intocommonmark:mainfrom
Closed
Enable adding own markdown renderers in builder#361kabir wants to merge 1 commit intocommonmark:mainfrom
kabir wants to merge 1 commit intocommonmark:mainfrom
Conversation
kabir
added a commit
to kabir/langchain4j
that referenced
this pull request
Jan 31, 2025
kabir
added a commit
to kabir/langchain4j
that referenced
this pull request
Feb 3, 2025
Note that this currently needs a SNAPSHOT of commonmark-java containing commonmark/commonmark-java#361.
kabir
added a commit
to kabir/langchain4j
that referenced
this pull request
Feb 3, 2025
This includes the change needed in commonmark/commonmark-java#361 and removes the previous snapshot
Draft
11 tasks
kabir
added a commit
to kabir/langchain4j
that referenced
this pull request
Feb 3, 2025
This includes the change needed in commonmark/commonmark-java#361 and removes the previous snapshot
Collaborator
Author
|
@robinst Great! Thank you |
Collaborator
|
@kabir FYI the fix has been released in 0.25.0 now: https://github.com/commonmark/commonmark-java/releases/tag/commonmark-parent-0.25.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NodeRendererMap refuses to write over the existing entries.
Looking a bit into it, it was because MarkdownRenderer.RendererContext iterates over the nodeRenderFactories in reverse order. This means that the last (i.e. the default) one is added first, making it impossible to override.
There were a few ways to fix this, but looking at the corresponding code in TextContentReader.RenderContext and HtmlRenderer.RenderContext, they iterate over the list of factories in the natural order.
@robinst @sebthom if you agree with the fix, it would be great if it could be included in a release soon :-)