Conversation
The only downside to defining it in `<plugins>` in the parent pom
is that there's a warning when running the plugin on the parent pom:
[INFO] --- bundle:5.1.9:manifest (bundle-manifest) @ commonmark-parent ---
[WARNING] Ignoring project type pom - supportedProjectTypes = [jar, bundle]
The upside is we don't have to remember to put the plugin into all the poms.
The configuration is as recommended here:
https://felix.apache.org/documentation/subprojects/apache-felix-maven-bundle-plugin-bnd.html#_adding_osgi_metadata_to_existing_projects_without_changing_the_packaging_type
Compared to the previous one, the only differences are:
- Import-Package adds imports for java packages, which seems to be recommended,
see bndtools/bnd#2507
- Import-Package of own packages that were exported (e.g. org.commonmark in core)
don't have the version number, not sure what's recommended there
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
=========================================
Coverage 94.94% 94.94%
Complexity 252 252
=========================================
Files 138 138
Lines 4471 4471
Branches 646 646
=========================================
Hits 4245 4245
Misses 122 122
Partials 104 104 🚀 New features to boost your workflow:
|
Collaborator
Author
|
FYI @zspitzer planning to merge and release this soon. |
Collaborator
Author
|
Released in 0.25.0 now: https://github.com/commonmark/commonmark-java/releases/tag/commonmark-parent-0.25.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing #359 because of some changes on top.