Repository navigation
refactor: remove benchmarkKind from benchsdk and benchmarks - #302
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor License AgreementAll contributors are covered by a CLA. |
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Storage Benchmark Results1MB Files
View full run · SVGs available as build artifacts |
Contributor
Sandbox Benchmark ResultsBurst
View full run · SVGs available as build artifacts |
Contributor
Snapshot/Fork Benchmark Resultssmall dataset
|
Contributor
Browser Benchmark Results
View full run · SVG available as build artifact |
Contributor
Browser Throughput Benchmark Results
View full run · SVG available as build artifact |
Contributor
AI Gateway Benchmark Results
View full run · SVG available as a build artifact |
kisernl
added a commit
that referenced
this pull request
Aug 11, 2026
Master removed benchmarkKind from the SDK and every bench file (#302); this benchmark was branched before that and was the last occurrence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
benchmarkKind/kindconcept entirely from the benchmark SDK, runner, and legacy ingestion flow.benchsdktypes:BenchmarkResource,UpsertBenchmarkInput, andUpdateBenchmarkInputno longer acceptkind;BenchmarkResultsOverviewandBenchmarkRunResultsno longer pick it.benchsdk-runner:BenchmarkConfig.benchmarkKindandBenchmarkShape.kindremoved;applyShapeand the platformupsertBenchmarkcall no longer pass akind.benchmarks/src/ingest.tsno longer derives or sendskind..bench.tsfiles and READMEs updated to dropbenchmarkKind.public-api.contract.test.ts,client.test.ts,integration.test.ts,runner.test.ts,bench-config.test.ts) updated.Verified with
pnpm typecheck,pnpm --filter @benchsdk/client test,pnpm --filter @benchsdk/runner test, andpnpm -r --filter "./packages/**" build.Link to Devin session: https://app.devin.ai/sessions/4f342077d5e64ce69e8b771e22845ec5
Requested by: @dtice25
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.