Repository navigation
Conversation
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/recipe.yaml:
tests:
- python:
python_version:
- ${{ python_min }}.*
- "*"
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/40762615598. Examine the logs at this URL for more detail. |
isuruf
marked this pull request as draft
October 28, 2026 20:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crossenv 1.6.0 applies its
packaging.tagspatch to pip's vendored copy too (robotpy/crossenv@3d00f75), so without--platform-tagpip in a cross environment only acceptslinux_<arch>wheels. Recipes that build a wheel, repair it with auditwheel and install it now fail, e.g. symengine-wheels:With 1.5.0 these wheels were accepted by accident: pip's vendored packaging was not patched, and crossenv's
_manylinux.pyis removed when cross-python deletesvenv/cross. The glibc version pip saw was the build machine's, not the target's.Patches:
CS_GLIBC_LIB_VERSION, which is not a valid name (callers useCS_GNU_LIBC_VERSION), and returnedglibc_2_17instead ofglibc 2.17. So it never applied and the build machine's glibc leaked into the cross environment. This bug is also on crossenv main.CONDA_BUILD=1and no platform tags are given, read the glibc version from<sysroot>/usr/include/features.hand uselinux_<arch>,manylinux_2_<N>_<arch>up to that version and the legacy aliases as platform tags. With 0006 this also makes confstr report the sysroot's glibc. Explicit--platform-tag/--manylinuxstill take precedence, and nothing changes outside conda-build or for non-linux targets.Also adds
wheelto run requirements: crossenv 1.6.x requires it andpip checkfails on main without it.Tested locally against an aarch64 python with pip 26.2.2, leaving
_manylinux.pyin place:os.confstr("CS_GNU_LIBC_VERSION")CONDA_BUILD=1, 2.17 sysrootlinux_aarch64,manylinux_2_17_aarch64,manylinux2014_aarch64glibc 2.17CONDA_BUILD=1, 2.28 sysrootmanylinux_2_18..manylinux_2_28glibc 2.28CONDA_BUILDlinux_aarch64unknown 0.0CONDA_BUILD=1+ explicit--platform-tagUnpatched 1.6.1 reports the build machine's glibc (
glibc 2.39locally).rattler-buildbuild and tests pass.This makes conda-forge/cross-python-feedstock#110 unnecessary; the two are compatible if both land.
🤖 Generated with Claude Code